Repository navigation
fix: support playground compiler API v9 - #1457
Closed
fhammerschmidt wants to merge 1 commit into
Closed
fhammerschmidt wants to merge 1 commit into
fhammerschmidt wants to merge 1 commit into
Conversation
Recognize the API version introduced by rescript-lang/rescript#8636 and route its bundles through the current ReScript compiler path. Keep the existing settings and language support available for v9. Add coverage for version recognition and settings alongside the existing legacy API tests. Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
cknitt
approved these changes
Oct 20, 2026
Member
Author
|
no changes, let's rather de-bump the compiler |
Contributor
Contributor
Lighthouse baselineCompared with target branch
Download the full Lighthouse reports and baseline Commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged rescript-lang/rescript#8636 raises the playground compiler API to v9. The website currently treats
"9"as an unknown version, so/trycannot compile with these bundles and its existing compiler settings are disabled.Recognize v9 in the shared API bindings and include it in the playground's modern compilation and open-module paths. Add a regression test for v9 recognition, available languages, and existing settings alongside the legacy-version tests.
Validation: