Skip to content

test: clean up visual baselines and verify component behavior - #1446

Open
fhammerschmidt wants to merge 3 commits into
masterfrom
fix/1421-visual-tests
Open

fhammerschmidt wants to merge 3 commits into
masterfrom
fix/1421-visual-tests

Conversation

@fhammerschmidt

@fhammerschmidt fhammerschmidt commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Remove seven unused screenshots and consolidate four duplicate visual fixtures while retaining their assertions.

Check TOC links and their destinations, verify computed strikethrough styling for deprecated tags, and render the real Markdown.Code component in the inline-code test. Use MemoryRouter in the touched component tests.

Part of #1421.
Fixes #1414

Remove orphan API and failure screenshots, and consolidate four identical visual fixtures while retaining their assertions. Verify active-page TOC links, deprecated tag styling, and the real inline-code component. Keep all remaining screenshot pixels unchanged and use MemoryRouter in the touched tests.

Fixes #1414
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T21:00:09.211520Z 4117b9f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
guide 9067856 Commit Preview URL

Branch Preview URL
Oct 14 2026, 08:36 PM

React Router resolves fragment links against the active page. Check the full current-page href for each TOC entry.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4117b9fdfc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/docs/__tests__/visual/DocsLayout_.test.res Outdated
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Lighthouse baseline

Compared with target branch master at commit 8f84bae. Scores are the median of 3 runs against the deployed Cloudflare preview.

Category Target Current Change
Performance 85 83 -2
Accessibility 80 80 0
Best practices 100 100 0
SEO 100 66 -34

Download the full Lighthouse reports and baseline

Commit 2bc30ab · Cloudflare preview

Retain consolidated assertions and MemoryRouter fixtures. Adapt the Markdown.Code test to its current React.element children API.
@github-actions

Copy link
Copy Markdown
Contributor

Docs preview

This branch was successfully deployed

2 active deployments
preview — 90678569 Deployed Oct 14, 2026 by github-actions[bot]
guide-preview — 90678569 Deployed Oct 14, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Orphan and duplicate visual baselines; vacuous visual tests

1 participant