Repository navigation
fix: honor HTTP-date Retry-After headers - #478
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
Signed-off-by: Kayvan Zahiri <kzahiri@dons.usfca.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicate's retry transport parses date-valued
Retry-Afterheaders withdatetime.fromisoformat(). Valid HTTP-date values such asSun, 18 Oct 2026 12:00:30 GMTfail parsing, so a response requesting a 30-second delay is retried after the default 0.1-second backoff.Add HTTP-date parsing using the standard library, treating timezone-free obsolete HTTP-date forms as UTC. Preserve existing ISO date compatibility, numeric delays, date delay cap, and fallback behavior for expired/malformed values. Both synchronous and asynchronous requests use the same helper.
Validation:
--record-mode=none: 202 passed, 6 skipped; no live predictions or API requests.--exit-zero) and reports existing unrelated warnings; no warnings on the added parsing code.HTTP-date contract: https://www.rfc-editor.org/rfc/rfc9110.html#name-retry-after