Repository navigation
Test that generated tests report the file of the original test - #3750
Open
Shakhtar-Sankur wants to merge 1 commit into
Open
Shakhtar-Sankur wants to merge 1 commit into
Shakhtar-Sankur wants to merge 1 commit into
Conversation
Tests generated with `--distribute`, `--repeat` and `-P` used to report ReFrame's own `testgenerators.py` as their file, for example in the failure report (reframe-hpc#3669). This was fixed by passing the module of the original test to `make_test()`; check it in the test generator unit tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests generated with
--distribute,--repeatand-Pused to report ReFrame's owntestgenerators.pyas their file, e.g. in the failure report (#3669). This was fixed in 4.10 by 9179c47, which passes the module of the original test tomake_test(), but nothing tests it. This PR adds a check to each of the three test generator unit tests that the generated tests report the same file as the original test.Testing:
reframe -c x.py -r --distribute=all --failure-statsreportstestgenerators.py(the bug); develop reportsx.py.unittests/test_testgenerators.pypasses, and the whole unit test suite passes (1451 passed, 280 skipped).testgenerators.pypart of 9179c47 reverted, so they catch the bug.Run log: https://www.kaggle.com/code/obsidian93/notebook094cf7bbfb
Closes #3669