Repository navigation
fix: handle uncompressed SVS-VAMANA indexes - #790
Open
itsrayeedscodespace wants to merge 1 commit into
Open
itsrayeedscodespace wants to merge 1 commit into
itsrayeedscodespace wants to merge 1 commit into
Conversation
vishal-bala
requested changes
Oct 27, 2026
vishal-bala
left a comment
Collaborator
There was a problem hiding this comment.
Hi, thanks for your contribution - please follow the pre-PR review guidelines outlined in CONTRIBUTING.md. We will wait until the PR has the expected "Reviewer Brief" section before assigning a human reviewer to it.
Author
|
Hi, thanks for the guidance! I've completed the pre-PR review following the repository's guidelines and added the Reviewer Brief to the PR description. The review covered all six areas, with no additional code changes needed. I've also included the remaining limitations and validation evidence. Appreciate your time, and looking forward to your feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
Closes #787
Description
Fixes an issue where
SearchIndex.from_existing()andAsyncSearchIndex.from_existing()fail to reconstruct SVS-VAMANA indexes created without compression.Redis returns
NO_COMPRESSIONinFT.INFO, which previously caused a Pydantic validation error during schema reconstruction.The fix treats
NO_COMPRESSIONas an omitted compression setting while preserving existing supported compression mappings.Testing
Added regression coverage for HASH and JSON indexes, multiple
FT.INFOresponse formats, and existing compression options.Validation:
Six regression cases reproduced the original validation error before the fix and passed afterward.
No public API changes or unrelated source modifications.
Release Notes
Existing SVS-VAMANA indexes created without compression can now be loaded successfully.
Reviewer Brief
Start here:
redisvl/redis/connection.py:516,convert_index_info_to_schema(): omitting Redis's no-compression sentinel lets both sync and asyncfrom_existing()validate the recovered SVS schema.Where it could fail
redisvl/redis/connection.py:518: check that onlyNO_COMPRESSIONis omitted; explicit compression mappings and JSON field paths must survive reconstruction.Not verified: live SVS recovery, cluster mode, other Redis/Python versions, full suite and provider APIs were not rerun in this review; tests used Python 3.13.12 and synthetic FT.INFO replies. The repository fixture started Redis, but these tests do not query it. Redis docs confirm compression defaults to none but do not specify the literal sentinel; earlier validation claims above are author-provided history.
Beyond CI: running the new matrix directly against the upstream merge-base converter produced six sentinel ValidationErrors and 54 passes; HEAD passed all 60 cases, without modifying source files.
Reviewed
3144e0472bfaea705e66748d65eea19924ee66d6· Codex (GPT-6; exact runtime model ID unavailable) · lenses: correctness, security, design, tests, docs, Redis behaviourNote
Low Risk
Narrow change to FT.INFO→schema conversion for SVS compression only; behavior for explicit compression mappings is unchanged.
Overview
Fixes
SearchIndex.from_existing()/AsyncSearchIndex.from_existing()failing when rebuilding SVS-VAMANA indexes that were created without compression.Redis
FT.INFOreportsNO_COMPRESSIONfor those indexes;convert_index_info_to_schemaused to pass that through and trigger Pydantic validation oncompression. The converter now ignoresNO_COMPRESSION(same as a missing compression setting) while keeping existing Redis→enum mappings (GlobalSQ8→LVQ4x4, etc.).Adds parametrized unit tests for HASH/JSON storage, dict/list/flags
FT.INFOshapes,NO_COMPRESSION/omitted compression, and supported compression values—including that uncompressed indexes omitcompressionfrom the recovered schema and Redis field args.Reviewed by Cursor Bugbot for commit 3144e04. Bugbot is set up for automated code reviews on this repo. Configure here.