[jgwest]

What does this PR do?

• A new version of gosec is reporting new warnings, causing CI failures
• This PR adds the appropriate tags to handle these warnings

PR acceptance criteria:

• Documentation was updated and verified using make serve-docs
• Unit tests were updated
• E2E tests were updated

What type of PR is this?
/kind failing-ci

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: redhat-developer/gitops-operator
• Branch: master
• File: .coderabbit.yaml
• Commit: b61fc0a
• Layers: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 82f29992-d285-4549-a625-6cb254028ddc

📥 Commits

Reviewing files that changed from the base of the PR and between b61fc0a and 8b39d45.

📒 Files selected for processing: 7

• argocd-operator/controllers/argocd/dex.go
• argocd-operator/controllers/argocd/image_updater.go
• argocd-operator/controllers/argocdagent/agent/deployment.go
• argocd-operator/controllers/argocdagent/deployment.go
• argocd-operator/tests/auxiliary/smtplistener/cmd/listener/serve.go
• argocd-operator/tests/ginkgo/fixture/argocd/fixture.go
• argocd-operator/tests/ginkgo/fixture/gitserver/repo.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• Bug Fixes
  • Failures during configuration reloads triggered by SIGHUP and log reopening triggered by SIGUSR1 are now reported in logs rather than silently ignored. This makes signal-related operational problems easier to notice and diagnose. The underlying operations and handling of other signals remain unchanged; only failure reporting has changed.

The diff adds gosec annotations to credential-like literals and test fixture code. It also logs errors returned by configuration reload and log reopening in the SMTP listener’s SIGHUP and SIGUSR1 handlers.

Changes: Gosec annotations

Layer / File(s)	Summary
Operator configuration and deployment annotations argocd-operator/controllers/argocd/dex.go, argocd-operator/controllers/argocd/image_updater.go, argocd-operator/controllers/argocdagent/agent/deployment.go, argocd-operator/controllers/argocdagent/deployment.go	Added #nosec G101 annotations to the Dex clientSecret placeholder and Secret resource names. The configuration values and volume behavior remain unchanged.
Test fixture annotations argocd-operator/tests/ginkgo/fixture/argocd/fixture.go, argocd-operator/tests/ginkgo/fixture/gitserver/repo.go	Added #nosec G124 and #nosec G204 comments for the outbound cookie and Git command construction. Executable behavior remains unchanged.

SMTP listener signal error logging

Layer / File(s)	Summary
Log signal operation errors argocd-operator/tests/auxiliary/smtplistener/cmd/listener/serve.go	The SIGHUP and SIGUSR1 handlers now log errors returned by configuration reload and log reopening. Previously, both errors were ignored.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: olivergondza, jaideepr97

Merge Risk: ⚪ Minimal · up to 8b39d

The PR is mergeable with no identified user-facing or operational risk.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 7 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly identifies the gosec warning fixes, which match the main changes.
Description check		The description accurately states that the PR addresses new gosec warnings by adding tags.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

_{Comment @coderabbitai help to get the list of available commands.}

[chengfang]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chengfang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• argocd-operator/OWNERS [chengfang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ranakan19]

Thanks!
/lgtm

[ranakan19]

Thanks!

[ranakan19]

/retest
terraform error; failed to create cluster

[chengfang]

/test v4.14-kuttl-parallel

[olivergondza]

/test v4.14-ci-index-gitops-operator-bundle

[olivergondza]

/test v4.14-images

[olivergondza]

/retest-required