Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the Argo CD upgrade from 3.5.2 to 3.5.4 and the Image Updater upgrade from 1.3.0 to 1.3.1. |
| Description check | ✅ Passed | The description states that the Argo CD and Image Updater dependencies are upgraded to keep the master branch current, and it links to the Image Updater release. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Comment @coderabbitai help to get the list of available commands.
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
….3.0 to 1.3.1 Signed-off-by: Cheng Fang <cfang@redhat.com>
5c6743b to
71304a3
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest-required |
# Conflicts: # argocd-operator/build/util/Dockerfile
|
merged from master and resolved conflict. |
|
@chengfang: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
superseded by #1446 |
What does this PR do?
upgrade image updater and argocd versions to keep master branch up-to-date.
https://github.com/argoproj-labs/argocd-image-updater/releases/tag/v1.3.1
PR acceptance criteria:
make serve-docsWhat type of PR is this?
/kind enhancement
Special notes to the reviewer: