Repository navigation
[perf] Read asserted class name off node in RemoveDeadInstanceOfAssertRector - #8726
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule drops
assert($x instanceof Foo)when $x is already of typeFoo. To get the asserted class type it readgetType($instanceof->class), which runs the type resolver over a class name node whose name is already known.A concrete class name is read straight off the node as
new ObjectType($name); theequals()/isSuperTypeOf()comparison against the expression type is unchanged, so the decision is identical.self/static/parentdepend on the enclosing class, so those fall back togetType().Bench
bench/remove_dead_instanceof_assert_name_type_bench.phpover 9000refactor()calls:Added
skip_self_instanceoffixture to pin theselffallback path (unchanged, matches current behaviour).