Skip to content

Make test AddFullyQualifiedIdentifierDocblockRector idempotent #8717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 19, 2026
Merged

Make test AddFullyQualifiedIdentifierDocblockRector idempotent #8717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...portFullyQualifiedIdentifierDocblock/Source/AddFullyQualifiedIdentifierDocblockRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ public function getNodeTypes(): array
public function refactor(Node $node)
{
$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);

// make rule idempotent, do not add if already present
if ($phpDocInfo->getVarTagValueNode() instanceof VarTagValueNode) {
return null;
}

$varTagValueNode = new VarTagValueNode(new FullyQualifiedIdentifierTypeNode('DateTime'), '', '');

$phpDocInfo->addTagValueNode($varTagValueNode);
Expand Down
Loading