Repository navigation
[perf] Compare property name before anonymous-class reflection in PropertyFetchFinder - #8712
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
findPropertyFetchesInClassLike()scans a class body for fetches of one property, eachPropertyFetchnode ranisInAnonymous()- which callsresolveClassReflection()- before the property name was compared. A class body references many different properties, so every fetch of an unrelated property paid for the anonymous-class reflection lookup only to fail the name check right after.The property name is now compared first; on a mismatch it bails before
isInAnonymous(). The outcome is unchanged: a name mismatch returned false either way (isNamePropertyNameEquals->isLocalPropertyFetchByNamerechecks the same name), andisInAnonymous()is a pure query with no side effect.Full test suite passes (4988 tests).
Bench included (
bench/property_fetch_finder_name_bench.php), scanning a class with 401 property fetches (only a couple match the target). CPU per scan, two runs each:~1.4x faster. The finder runs in dead-code, privatization and readonly rules that scan class bodies for property usage.