Repository navigation
Convert nested arrow functions to anonymous functions in a single pass - #413
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an arrow function body is itself an arrow function, convert the inner one in the same pass instead of leaving it for another traverse.
A deeply nested chain (
fn() => fn() => fn() => ...) previously needed one pass per level. With the rector-src fixed-point loop now capped, a chain deeper than the cap would fail to stabilize. Handling the nested case inline downgrades the whole chain in one pass.Output is unchanged - the existing
nested_static_fn_usesfixtures (includingtoomany,mixed,sameParamName) pass as before.