Skip to content

Declare explicit union return types for returned union params #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 16, 2026
Merged

Declare explicit union return types for returned union params #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rules/DowngradePhp80/Rector/ClassMethod/DowngradeTrailingCommasInParamUseRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,12 @@ private function processParams(ClassMethod|Function_|Closure $node): ?Node
}

/**
* @template TNode of Closure|ClassMethod|Function_
* @param TNode $node
* @param ClosureUse[]|Param[] $array
* @return TNode|null
*/
private function cleanTrailingComma(Closure|ClassMethod|Function_ $node, array $array): ?Node
private function cleanTrailingComma(Closure|ClassMethod|Function_ $node, array $array): Closure|ClassMethod|Function_|null
{
$lastPosition = array_key_last($array);

Expand Down
5 changes: 4 additions & 1 deletion rules/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,12 @@ public function refactor(Node $node): ?Node
}

/**
* @template TNode of MethodCall|StaticCall|New_|FuncCall
* @param TNode $node
* @param Arg[] $args
* @return TNode|null
*/
private function removeNamedArguments(MethodCall|StaticCall|New_|FuncCall $node, array $args): ?Node
private function removeNamedArguments(MethodCall|StaticCall|New_|FuncCall $node, array $args): FuncCall|MethodCall|New_|StaticCall|null
{
if ($node instanceof New_) {
$functionLikeReflection = $this->reflectionResolver->resolveMethodReflectionFromNew($node);
Expand Down
Loading