Repository navigation
Conversation
Contributor
Author
|
Draft PR for reporter to test. |
pelwell
approved these changes
Oct 12, 2026
Collaborator
|
@t-8ch - I think this wants fixing upstream. |
Contributor
Yes, agreed. @6by9 Can you submit this upstream? Maybe it should change to this: } while (hrtimer_get_expires(timer) < hrtimer_cb_get_time(timer));This is closer to the original logic and IMO easier to understand. |
Contributor
Author
|
Yup, happy to submit it upstream, making your suggested change first. I'll update this PR too so hopefully we'll avoid merge conflicts when it does merge back through stable. |
Commit 44d7fb8 ("media: pwm-ir-tx: Avoid direct access to hrtimer clockbase") converted a loop conditional from now = timer->base->get_time(); } while (hrtimer_get_expires_tv64(timer) < now); to while (hrtimer_expires_remaining(timer) > 0); hrtimer_expires_remaining returns (expires - now), so the change has inverted the condition. Convert back to follow the original pattern, but using the proper API call. Fixes: 44d7fb8 ("media: pwm-ir-tx: Avoid direct access to hrtimer clockbase") Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Contributor
Author
|
PR updated based on suggested option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 44d7fb8 ("media: pwm-ir-tx: Avoid direct access to hrtimer clockbase") converted a loop conditional from
now = timer->base->get_time();
} while (hrtimer_get_expires_tv64(timer) < now);
to
while (hrtimer_expires_remaining(timer) > 0);
hrtimer_expires_remaining returns (expires - now), so the change has inverted the condition.
Correct the > to < to restore the old behaviour
#7678
Fixes: 44d7fb8 ("media: pwm-ir-tx: Avoid direct access to hrtimer clockbase")