Skip to content

Tweak light/dark theme query source for a few more controls - #827

Merged
rfindler merged 2 commits into
racket:masterfrom
shhyou:three-more
Sep 24, 2026
Merged

rfindler merged 2 commits into
racket:masterfrom
shhyou:three-more

Conversation

@shhyou

@shhyou shhyou commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Closes #823. Modified controls:

  • File/directory drop-down menu
  • (define ...) drop-down menu
  • "Submodules to Run" drop-down menu
  • "Always use the same #lang line" text field
  • "Limit Memory..." text field

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 2 files in this pull request and found no issues.

@rfindler

Copy link
Copy Markdown
Member

It took me a little thinking to agree about the change in turn-on/off-auto-text-text-box, but I think you're right: those colors are, in principle, being controlled by the os-level settings, not the theming that DrRacket offers, so fixing them to specific colors makes sense (as the drracket-level theming doesn't apply to controls in dialogs).

@rfindler
rfindler merged commit 4e9cda7 into racket:master Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The background of dropdown menus is very dark on mouse over

2 participants