Repository navigation
chore: add Robie and Loïc to CODEOWNERS - #166
Open
Christopher Obbard (obbardc) wants to merge 1 commit into
Open
Christopher Obbard (obbardc) wants to merge 1 commit into
Christopher Obbard (obbardc) wants to merge 1 commit into
Conversation
Christopher Obbard (obbardc)
had a problem deploying
to
Staging
October 30, 2026 13:40 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Christopher Obbard (obbardc)
deployed
to
Staging
October 30, 2026 13:40 — with
GitHub Actions
Active
GitHub Actions
Active
Christopher Obbard (obbardc)
deployed
to
Staging
October 30, 2026 13:40 — with
GitHub Actions
Active
GitHub Actions
Active
Christopher Obbard (obbardc)
had a problem deploying
to
Staging
October 30, 2026 13:40 — with
GitHub Actions
Failure
GitHub Actions
Failure
Christopher Obbard (obbardc)
had a problem deploying
to
Staging
October 30, 2026 13:41 — with
GitHub Actions
Failure
GitHub Actions
Failure
Christopher Obbard (obbardc)
deployed
to
Staging
October 30, 2026 13:41 — with
GitHub Actions
Active
GitHub Actions
Active
|
I'm happy to be a backup. I expect I'll generally defer to you and Bjordis when you're available though. I'm really happy with the progress you've both made in this codebase and would be worried about stepping on your toes. |
Christopher Obbard (obbardc)
marked this pull request as ready for review
October 30, 2026 21:14
Christopher Obbard (obbardc)
requested a review
from Bjordis Collaku (bjordiscollaku)
as a code owner
October 30, 2026 21:15
Only two people are asked to review pull requests into main, so a change can sit waiting whenever either of them is busy or away. Add Robie Basak (basak-qcom) and Loïc Minier (lool) to the rule so GitHub requests them too, widening the pool of reviewers. Both have an admin role on the repository which GitHub requires for an owner to take effect. CODEOWNERS has no notion of primary and secondary owners: everyone listed is requested and an approval from any one of them is enough, so they are appended after the existing owners. Signed-off-by: Christopher Obbard <chris.obbard@oss.qualcomm.com>
Christopher Obbard (obbardc)
force-pushed
the
wip/obbardc/codeowners-more-reviewers
branch
from
October 30, 2026 21:17
7e26565 to
8784de8
Compare
Christopher Obbard (obbardc)
had a problem deploying
to
Staging
October 30, 2026 21:23 — with
GitHub Actions
Failure
GitHub Actions
Failure
Christopher Obbard (obbardc)
had a problem deploying
to
Staging
October 30, 2026 21:23 — with
GitHub Actions
Failure
GitHub Actions
Failure
Christopher Obbard (obbardc)
deployed
to
Staging
October 30, 2026 21:23 — with
GitHub Actions
Active
GitHub Actions
Active
Christopher Obbard (obbardc)
deployed
to
Staging
October 30, 2026 21:23 — with
GitHub Actions
Active
GitHub Actions
Active
Christopher Obbard (obbardc)
had a problem deploying
to
Staging
October 30, 2026 21:24 — with
GitHub Actions
Failure
GitHub Actions
Failure
Christopher Obbard (obbardc)
deployed
to
Staging
October 30, 2026 21:25 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only two people are asked to review pull requests into main, so a change can sit waiting whenever either of them is busy or away.
Add Robie Basak (@basak-qcom) and Loïc Minier (@lool) to the rule so GitHub requests them too, widening the pool of reviewers. Both have an admin role on the repository which GitHub requires for an owner to take effect. CODEOWNERS has no notion of primary and secondary owners: everyone listed is requested and an approval from any one of them is enough, so they are appended after the existing owners.
I have left this as a draft as it will add you both to ALL future PRs. Perhaps we don't want to do this, but I am opening this PR to start the discussion :-).