[Nihal Kumar Gupta (nihal231998)]

OPE uses pm_clk to manage its clocks. pm_clk prepares clocks when they are added, but runtime suspend only disables normal clocks, leaving the CAMSS OPE clocks prepared while idle.

Manage the OPE clocks directly with bulk clock helpers so runtime suspend disables and unprepares them.

Fixes: 4e5f65d2011b ("media: qcom: camss: Add CAMSS Offline Processing Engine driver")

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qlijarvis]

PR #1370 — validate-patch

PR: #1370

Verdict	Issues	Detailed Report
❌	7	Full report

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix to indicate this is vendor-only work
2. Lore link matches PR commits: N/A — cannot validate without a lore link
3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix
4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Required actions before merge:

1. Add appropriate vendor prefix to subject line (FROMLIST:, QCLINUX:, etc.)
2. If this is posted upstream, add Link: https://lore.kernel.org/r/<message-id> tag
3. If this is vendor-only work, use QCLINUX: prefix (no link required)
4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1370 - media: qcom: camss: Fully unprepare OPE clocks on suspend
Upstream commit: N/A (no lore.kernel.org link found)
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	No upstream link to compare against
Body preserves rationale	N/A	No upstream link to compare against
Fixes tag present/correct	✅	Fixes: 4e5f65d2011b present
Authorship preserved	N/A	No upstream link to compare against
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/media/platform/qcom/camss/ope/core.c	❌	Cannot validate - no lore link to compare against

Issues

Critical: Missing lore.kernel.org link

• The commit message contains no Link: tag pointing to lore.kernel.org
• The commit subject has no vendor prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, etc.)
• Without a lore link or vendor prefix, the patch origin and upstream status cannot be determined

Commit message structure issues:

• Missing required prefix: commits should be prefixed with one of:
  • UPSTREAM: if merged into Linus's tree (with lore/git.kernel.org link)
  • FROMLIST: if posted to mailing list but not yet merged (with lore link)
  • BACKPORT: if backported with modifications (with original lore link)
  • QCLINUX: if vendor-only, no upstream equivalent (no link required)
  • PENDING: if work-in-progress, not yet posted (no link required)

Integration presence:

• Per integration_presence_report.md: PARTIAL - only partial evidence found in qcom-next
• The commit shows "partial - subject or partial tree evidence found, but full change was not verified"
• This suggests the change may exist in a different form or is incomplete in the integration branch

Verdict

Do not merge without correction. The patch lacks the required lore.kernel.org link and vendor prefix, making it impossible to validate against upstream sources or determine its origin and acceptance status.

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix to indicate this is vendor-only work
2. Lore link matches PR commits: N/A — cannot validate without a lore link
3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix
4. PR present in qcom-next/topics: Partial — only partial evidence found per integration_presence_report.md; full change not verified in qcom-next or topics

Required actions before merge:

1. Add appropriate vendor prefix to subject line (FROMLIST:, QCLINUX:, etc.)
2. If this is posted upstream, add Link: https://lore.kernel.org/r/<message-id> tag
3. If this is vendor-only work, use QCLINUX: prefix (no link required)
4. Investigate why integration presence check shows only "partial" match

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ae2606baf50f01e14ed7ddfa73116e5850c6c0d1
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] media: qcom: camss: Fully unprepare OPE clocks on suspend	partial - subject or partial tree evidence found, but full change was not verified	missing - no subject, patch-id, or full tree-content match found	partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

[qlijarvis]

PR #1370 — checker-log-analyzer

PR: #1370
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41081432220

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 warnings: unknown commit ID, missing blank line
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject prefix required (assuming non-qcom-next branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1370 - media: qcom: camss: Fully unprepare OPE clocks on suspend
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41081432220

Checker	Result	Summary
checkpatch	❌	2 warnings: unknown commit ID, missing blank line
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject prefix required (assuming non-qcom-next branch)

---

❌ checkpatch

Root cause: Two style issues in commit ba5cc08

Failure details:

WARNING: Unknown commit id '4e5f65d2011b', maybe rebased or not pulled?
#13: 
Fixes: 4e5f65d2011b ("media: qcom: camss: Add CAMSS Offline Processing Engine driver")

WARNING: Missing a blank line after declarations
#95: FILE: drivers/media/platform/qcom/camss/ope/core.c:3825:
+	struct ope_dev *ope = dev_get_drvdata(dev);
+	clk_bulk_disable_unprepare(ope->nclks, ope->clks);

ba5cc08c9451f8a3f3a784abd326a3af6e8432bd total: 0 errors, 2 warnings, 0 checks, 89 lines checked

Fix:

1. Unknown commit ID warning — This is a false positive. The commit 4e5f65d2011b exists in the tree but checkpatch cannot resolve it in the CI environment. This warning can be ignored if the commit ID is valid in the target branch.

2. Missing blank line after declarations — Add a blank line between the variable declaration and the function call:

git rebase -i 4b7f69a1ee2e   # mark commit ba5cc08c9451 as 'edit'
# Edit drivers/media/platform/qcom/camss/ope/core.c:3825
# Change:
#   struct ope_dev *ope = dev_get_drvdata(dev);
#   clk_bulk_disable_unprepare(ope->nclks, ope->clks);
# To:
#   struct ope_dev *ope = dev_get_drvdata(dev);
#
#   clk_bulk_disable_unprepare(ope->nclks, ope->clks);

git add drivers/media/platform/qcom/camss/ope/core.c
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 4b7f69a1ee2e..ba5cc08c9451

---

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:)

Failure details:

Checking commit: media: qcom: camss: Fully unprepare OPE clocks on suspend
Commit summary does not start with a required prefix

Fix:

The commit subject must start with one of the allowed prefixes. Additionally, a Link: tag pointing to the upstream lore.kernel.org patch is required.

If this patch has been posted upstream:

git rebase -i 4b7f69a1ee2e   # mark commit as 'edit'
git commit --amend -m "FROMLIST: media: qcom: camss: Fully unprepare OPE clocks on suspend

OPE uses pm_clk to manage its clocks. pm_clk prepares clocks when they
are added, but runtime suspend only disables normal clocks, leaving the
CAMSS OPE clocks prepared while idle.

Manage the OPE clocks directly with bulk clock helpers so runtime
suspend disables and unprepares them.

Link: https://lore.kernel.org/linux-media/<message-id>
Fixes: 4e5f65d2011b (\"media: qcom: camss: Add CAMSS Offline Processing Engine driver\")
Signed-off-by: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>"
git rebase --continue

If this patch has NOT been posted upstream yet:

Use PENDING: prefix (note: this will still fail check-patch-compliance as it only accepts upstream-linkable prefixes, but it's the correct semantic tag):

git commit --amend -m "PENDING: media: qcom: camss: Fully unprepare OPE clocks on suspend
...

If this is a vendor-only change:

Use QCLINUX: prefix (note: this will also fail check-patch-compliance — known limitation):

git commit --amend -m "QCLINUX: media: qcom: camss: Fully unprepare OPE clocks on suspend
...

Reproduce locally:

# Verify the patch can be fetched from lore (if FROMLIST/UPSTREAM)
b4 am --single-message -C -l -3 <lore-url>

---

❌ tag-check

Root cause: Subject line does not start with a required prefix tag

Failure details:

The commit subject media: qcom: camss: Fully unprepare OPE clocks on suspend has no prefix tag.

Note: This check applies to all branches except qcom-next and qcom-next-staging. If this PR targets one of those branches, this check should be skipped. However, based on the check-patch-compliance failure pattern, this appears to target a different branch.

Fix:

Add the appropriate prefix based on the patch origin:

Situation	Prefix
Posted to lore, not yet merged	FROMLIST:
In a maintainer git tree	FROMGIT:
Merged into Linus's tree	UPSTREAM:
Backported with modifications	BACKPORT:
Vendor-only, no upstream	QCLINUX:
Work-in-progress, not posted	PENDING:

git rebase -i 4b7f69a1ee2e   # mark commit as 'edit'
git commit --amend -m "FROMLIST: media: qcom: camss: Fully unprepare OPE clocks on suspend"
# (include full commit body with Link: tag)
git rebase --continue

---

Verdict

3 blockers must be fixed before merge:

1. checkpatch — Add blank line after variable declaration (trivial fix)
2. check-patch-compliance — Add required subject prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:) and Link: tag
3. tag-check — Same as Adding Email Checker  #2 (subject prefix requirement)

Recommended action:

1. Determine if this patch has been posted to lore.kernel.org
2. If yes: Add FROMLIST: prefix + Link: tag pointing to the lore URL
3. If no: Post to upstream first, then add FROMLIST: + Link:, OR use PENDING:/QCLINUX: (with the understanding that check-patch-compliance will continue to fail for vendor-only tags)
4. Fix the blank line style issue in core.c:3825
5. Re-run CI

The checkpatch "Unknown commit id" warning is likely a false positive if the Fixes: commit exists in the target branch — verify locally but no action needed if valid.