Skip to content

arm64: dts: qcom: kodiak: Add CSIPHY mux mode device tree entries - #1369

Open
nikolay-qc wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
nikolay-qc:qli2.0_mux_mode_dt_entry
Open

nikolay-qc wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
nikolay-qc:qli2.0_mux_mode_dt_entry

Conversation

@nikolay-qc

Copy link
Copy Markdown

Two new entries are added to CSIPHY device tree. They are used when CSIPHY will be used in mux mode.
Added entries:

mux-mode
session-max-device-supported

CRs-Fixed: 4729604

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4729604 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4729604

Please ensure the CR has a change task associated with at least one of the entities for this branch.

…ntries

Two new entries are added to CSIPHY device tree. They
are used when CSIPHY will be used in mux mode.
Added entries:

mux-mode
session-max-device-supported

Signed-off-by: Nikolay Nikolov <nikolay@qti.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1369 — validate-patch

PR: #1369

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; missing required Link: tag
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Not upstream — no evidence of mailing list posting or upstream merge
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1369 - arm64: dts: qcom: kodiak: Add CSIPHY mux mode device tree entries
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No lore link to compare against
Body preserves rationale ⚠️ Minimal description; no technical rationale for property values
Fixes tag present/correct N/A Not a fix commit
Authorship preserved N/A No upstream source to verify
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi ⚠️ Adds undocumented DT properties without bindings

Issues

  1. Missing lore.kernel.org link — No Link: tag found in commit message. Per kernel submission guidelines, device tree changes should reference either:

    • An upstream lore posting (FROMLIST: prefix)
    • A merged upstream commit (UPSTREAM: or BACKPORT: prefix)
    • Or be marked as vendor-specific (QCLINUX: prefix)
  2. Missing commit prefix — Subject line lacks a standard prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, etc.) to indicate the patch's upstream status.

  3. Undocumented device tree properties — The patch adds two new DT properties (mux-mode and session-max-device-supported) without:

    • Corresponding dt-bindings documentation
    • Reference to where these properties are defined
    • Explanation of valid values and their meaning
  4. Commit message lacks technical detail — The description states what is added but not why. Missing:

    • Use case or hardware requirement for mux mode
    • Why mux-mode = <1> and session-max-device-supported = <2> are the correct values
    • Impact on camera functionality
  5. Not present in qcom-next or topics — Per integration_presence_report.md, this commit is missing from both qcom-next and all kernel topic branches, indicating it has not been integrated into any Qualcomm kernel tree.

Verdict

Do not merge. This patch requires significant rework:

  1. Add appropriate commit prefix (QCLINUX: if vendor-only, or FROMLIST: with lore link if posted upstream)
  2. If these are vendor-specific properties, document them in vendor dt-bindings or explain why they're not upstreamable
  3. If these properties should be upstream, post to devicetree mailing list first with proper bindings documentation
  4. Expand commit message with technical rationale for the property values
  5. Ensure the commit is present in the appropriate topic branch before PR submission

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; missing required Link: tag
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Not upstream — no evidence of mailing list posting or upstream merge
  4. PR present in qcom-next/topics: Fail — commit missing from both qcom-next and all topic branches (0/1 commits present)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ae2606baf50f01e14ed7ddfa73116e5850c6c0d1
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] arm64: dts: qcom: kodiak: Add CSIPHY mux mode device tree missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1369 — checker-log-analyzer

PR: #1369
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41068736108

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ Pre-existing tree issues in qcs6490-camera.dtsi
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Missing subject prefix
tag-check ❌ Missing subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1369 - arm64: dts: qcom: kodiak: Add CSIPHY mux mode device tree entries
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41068736108

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ Pre-existing tree issues in qcs6490-camera.dtsi
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Missing subject prefix
tag-check ❌ Missing subject prefix (mandatory for qcom-6.18.y)

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

Checking commit: arm64: dts: qcom: kodiak: Add CSIPHY mux mode device tree entries
Commit summary does not start with a required prefix

Fix: Add a subject prefix based on the patch origin:

git rebase -i 4b7f69a1ee2e59e0206ed610734d40c2c9521bcc
# mark commit 9f7dc771ef11 as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: kodiak: Add CSIPHY mux mode device tree entries"
# (keep the rest of the commit message unchanged)
git rebase --continue

Choose the correct prefix:

  • FROMLIST: if posted to lore.kernel.org
  • FROMGIT: if taken from a maintainer tree
  • UPSTREAM: if merged into Linus's mainline
  • BACKPORT: if backported with modifications
  • QCLINUX: if vendor-only (no upstream equivalent)

Reproduce locally:

# The checker will always fail for QCLINUX: prefix (known limitation)
# If this is vendor-only, the failure is expected

❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so every commit must start with a subject prefix.

Failure details:

Commit 9f7dc771ef11 ("arm64: dts: qcom: kodiak: Add CSIPHY mux mode device tree entries")
Subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Same as check-patch-compliance above — add the appropriate prefix to the commit subject.


❌ dtb-check

Root cause: Pre-existing tree issues in qcs6490-camera.dtsi (not introduced by this PR).

Failure details:
The PR adds only 2 lines at line 1578-1579:

+		mux-mode = <1>;
+		session-max-device-supported = <2>;

However, dtb-check reports 101 warnings in qcs6490-camera.dtsi, all on different line numbers (1601, 1655, 1688, 1721, 1767, 1821, 1876, 1931, 1979, etc.):

Warning (reg_format): /fragment@0/__overlay__/qcom,ipe0:reg: property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): /fragment@0/__overlay__/qcom,csiphy4: Relying on default #address-cells value
Warning (interrupts_property): /fragment@0/__overlay__/qcom,csiphy4: Missing interrupt-parent

Analysis: These are pre-existing issues in the camera DTSI file. The PR only touches lines 1578-1579, but the errors are on lines 1549-2024 (camera device nodes defined elsewhere in the file). The dtb-check baseline subtraction should have filtered these out, but they appear because the file was modified (triggering a rebuild of all DTBs that include it).

Fix: None required for this PR. These are tree-wide issues that should be fixed separately:

  1. reg_format errors: Fix #address-cells/#size-cells mismatch in camera nodes
  2. avoid_default_addr_size: Add explicit #address-cells = <1>; #size-cells = <0>; to camera nodes
  3. interrupts_property: Add interrupt-parent property to camera nodes

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb

Verdict

2 blockers to fix before merge:

  1. Missing subject prefix — Add QCLINUX: (or appropriate prefix) to the commit subject
  2. dtb-check failures — These are pre-existing tree issues, not introduced by this PR. The PR only adds 2 properties to an existing node. The 101 warnings are in other camera nodes (lines 1549-2024) that were already broken. Recommendation: Merge the PR after fixing the subject prefix; file a separate issue to fix the pre-existing dtb-check errors in qcs6490-camera.dtsi.

Note: If this is a vendor-only change (QCLINUX: prefix), check-patch-compliance will always fail — this is a known checker limitation for vendor-only commits.

@nikolay-qc
nikolay-qc force-pushed the qli2.0_mux_mode_dt_entry branch from 9f7dc77 to a2e9254 Compare October 30, 2026 15:00
@qlijarvis

Copy link
Copy Markdown

PR #1369 — validate-patch

PR: #1369

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1369 - QCLINUX: arm64: dts: qcom: qcs6490: Add CSIPHY mux mode device tree entries
Upstream commit: N/A (vendor-only)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale ✅ Clear description of added properties
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved ✅ Nikolay Nikolov properly attributed
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi ✅ Adds two vendor-specific CSIPHY mux mode properties

Verdict

Merge as-is. This is a vendor-only device tree change with proper commit message formatting and clear attribution.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and topics (expected for new vendor-only changes awaiting integration)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ae2606baf50f01e14ed7ddfa73116e5850c6c0d1
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: qcs6490: Add CSIPHY mux mode missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1369 — checker-log-analyzer

PR: #1369
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41077083074

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ 6 new reg_format errors in qcs6490-camera.dtsi
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ❌ QCLINUX: prefix not valid for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1369 — QCLINUX: arm64: dts: qcom: qcs6490: Add CSIPHY mux mode device tree entries
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41077083074
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ 6 new reg_format errors in qcs6490-camera.dtsi
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ❌ QCLINUX: prefix not valid for qcom-6.18.y branch

❌ dtb-check

Root cause: The PR modifies qcs6490-camera.dtsi:1576, which triggers a rebuild of DTBs that expose pre-existing reg_format errors in the same file.

Failure details:

../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1601.3-36: Warning (reg_format): 
  /fragment@0/__overlay__/qcom,ipe0:reg: property has invalid length (16 bytes) 
  (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1655.3-1656.38: Warning (reg_format): 
  /fragment@0/__overlay__/qcom,jpegdma:reg: property has invalid length (32 bytes) 
  (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1688.3-1689.38: Warning (reg_format): 
  /fragment@0/__overlay__/qcom,jpegenc:reg: property has invalid length (32 bytes) 
  (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1721.3-36: Warning (reg_format): 
  /fragment@0/__overlay__/qcom,lrme:reg: property has invalid length (16 bytes) 
  (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1767.3-36: Warning (reg_format): 
  /fragment@0/__overlay__/qcom,vfe0:reg: property has invalid length (16 bytes) 
  (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1821.3-36: Warning (reg_format): 
  /fragment@0/__overlay__/qcom,vfe1:reg: property has invalid length (16 bytes) 
  (#address-cells == 2, #size-cells == 1)

Analysis: These are pre-existing errors in qcs6490-camera.dtsi (lines 1601, 1655, 1688, 1721, 1767, 1821), not introduced by this PR. The PR only modifies line 1576 (adding mux-mode and session-max-device-supported properties). The dtb-check baseline subtraction should have filtered these out, but they appear because the base build may have been incomplete or the file wasn't built at base.

The reg_format errors indicate that reg properties have incorrect byte lengths given the parent node's #address-cells and #size-cells values. This is a tree-wide issue in the camera DTSI overlay files.

Fix: These errors are not caused by this PR. However, if you want to fix them:

  1. Check the parent node's #address-cells and #size-cells values
  2. Adjust each reg property to match: reg length must be (#address-cells + #size-cells) × 4 bytes
  3. For example, if #address-cells == 2 and #size-cells == 1, each reg entry must be 12 bytes (3 cells)

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb

❌ check-patch-compliance

Root cause: The commit subject starts with QCLINUX:, which is not in the checker's allowed prefix list.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: qcs6490: Add CSIPHY mux mode device tree entries
Commit summary does not start with a required prefix

Analysis: The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from a maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

QCLINUX: is a vendor-internal prefix used for Qualcomm-only changes with no upstream equivalent. This is a known checker limitation — vendor-only commits will always fail this check.

Fix: If this change has been or will be posted upstream, change the prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL. If this is genuinely vendor-only with no upstream equivalent, the checker will continue to fail — this is expected behavior for QCLINUX: commits.

Reproduce locally:

# The checker script is not designed to pass QCLINUX: commits
# This is a known limitation for vendor-only changes

❌ tag-check

Root cause: The target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), which requires all commits to start with a valid upstream-linkable prefix. QCLINUX: is not accepted for this branch.

Failure details:

Commit a2e9254a5588 ("QCLINUX: arm64: dts: qcom: qcs6490: Add CSIPHY mux mode device tree entries")
Subject line starts with: QCLINUX:
Target branch: qcom-6.18.y

Analysis: All branches except qcom-next and qcom-next-staging require commits to carry one of these prefixes:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / PENDING: / WORKAROUND:

QCLINUX: is not a valid prefix for qcom-6.18.y. This is a branch policy enforcement — only upstream-linkable or explicitly tagged vendor changes are allowed.

Fix:

git rebase -i <base_sha>   # mark commit as 'edit'
# Choose the appropriate prefix based on the patch origin:
# - If posted to lore.kernel.org → FROMLIST:
# - If in a maintainer tree → FROMGIT:
# - If merged into Linus's tree → UPSTREAM:
# - If vendor-only work-in-progress → PENDING:
# - If temporary workaround → WORKAROUND:
git commit --amend -m "PENDING: arm64: dts: qcom: qcs6490: Add CSIPHY mux mode device tree entries

Two new entries are added to CSIPHY device tree. They
are used when CSIPHY will be used in mux mode.
Added entries:

mux-mode
session-max-device-supported

Signed-off-by: Nikolay Nikolov <nikolay@qti.qualcomm.com>"
git rebase --continue

If this change is intended for upstream submission, use FROMLIST: and add a Link: trailer. If it's vendor-only, use PENDING: or WORKAROUND: depending on the nature of the change.


Verdict

2 blockers must be fixed before merge:

  1. check-patch-compliance + tag-check: Change the commit prefix from QCLINUX: to an accepted prefix (FROMLIST:, PENDING:, or WORKAROUND:) based on the patch's upstream status. For qcom-6.18.y branch, QCLINUX: is not allowed.

  2. dtb-check: The 6 reg_format errors are pre-existing tree issues in qcs6490-camera.dtsi, not introduced by this PR. However, they are now exposed because the PR triggers a rebuild of the affected DTBs. These should ideally be fixed in a separate cleanup commit, but they do not block this PR if the baseline subtraction is corrected.

Recommended action: Fix the commit prefix (blocker #1), then re-run CI. The dtb-check errors are pre-existing and should be addressed separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants