FROMLIST: arm64: dts: qcom: update Talos Lyra EVK model name by nkumarsi · Pull Request #1368 · qualcomm-linux/kernel

nkumarsi · 2026-10-30T11:21:44Z

Update the Talos Lyra EVK model string to align with the upstream naming convention.

Link: https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-3-658fd5a7ec99@oss.qualcomm.com/

Update the Talos Lyra EVK model string to align with the upstream naming convention. Link: https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-3-658fd5a7ec99@oss.qualcomm.com/ Signed-off-by: Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>

qswat-orbit-external · 2026-10-30T11:22:08Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-10-30T11:23:48Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-10-30T11:24:42Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-10-30T11:25:50Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qlijarvis · 2026-10-30T12:24:32Z

PR #1368 — validate-patch

PR: #1368

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: Yes — https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-3-658fd5a7ec99@oss.qualcomm.com/
Lore link matches PR commits: No — PR contains only 1 line (model string) from a 115-line new-file patch; missing 114 lines of new DTS content, 5 lines of Makefile changes, and 2 prerequisite patches (1/3 dt-bindings, 2/3 SoM DTSI). Authorship is incorrect (missing original author's Signed-off-by). Subject and body misrepresent the scope.
Upstream patch status: ⏳ Decision Pending — posted Oct 27, 2026 (3 days ago). Maintainer Krzysztof Kozlowski replied on Oct 27 requesting clarification on SoM compatible design for patch 1/3 (dt-bindings). No acceptance or rejection signal for patch 3/3 yet. Active review in progress.
PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1368 - FROMLIST: arm64: dts: qcom: update Talos Lyra EVK model name
Upstream commit: https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-3-658fd5a7ec99@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note

Subject matches upstream ❌ PR subject is "update Talos Lyra EVK model name" but upstream is "Add Talos Lyra EVK board" — completely different scope

Body preserves rationale ❌ PR body is minimal ("align with upstream naming convention") while upstream describes full board bring-up with peripherals, co-authors, and context

Fixes tag present/correct N/A Not applicable — this is new board support, not a fix

Authorship preserved ❌ PR From: is Nirmesh Kumar Singh but upstream From: is Avaneesh Kumar Dwivedi (original author); Nirmesh is only listed as Tested-by: in upstream

Backport note (if applicable) N/A Not a backport — this is a FROMLIST: commit

Diff

File Status Notes

arch/arm64/boot/dts/qcom/talos-lyra-evk.dts ❌ PR changes only 1 line (model string); upstream adds 115 lines (entire new board DTS file)

arch/arm64/boot/dts/qcom/Makefile ❌ Missing from PR — upstream adds 5 lines for new DTB targets

Issues

Critical mismatch: PR is a fragment of patch 3/3 from a 3-patch series

Wrong scope: The PR extracts only the model string change (line 10 of the new file) from upstream patch 3/3, which adds the entire Talos Lyra EVK board DTS (115 lines) plus Makefile entries. The PR subject and body misrepresent this as a simple "update" when upstream is adding a new board.

Missing dependencies: The upstream series has 3 patches:

Patch 1/3: dt-bindings for Talos Lyra EVK

Patch 2/3: Talos Lyra EVK SoM DTSI (281 lines)

Patch 3/3: Talos Lyra EVK board DTS (115 lines) + Makefile

The PR cherry-picks only 1 line from patch 3/3 without patches 1/3 or 2/3, and without the rest of patch 3/3. This creates a broken reference: the PR modifies talos-lyra-evk.dts at line 10, but that file does not exist in the tree without the full patch 3/3.

Authorship violation (FROMLIST: rule): The PR From: is Nirmesh Kumar Singh, but the upstream author is Avaneesh Kumar Dwivedi. For FROMLIST: commits, the submitter may differ from the lore author, but the original author's Signed-off-by: must be present. The PR commit message has only Nirmesh's Signed-off-by: — Avaneesh's Signed-off-by: is missing.

Incomplete commit message: The PR omits all co-authors (Co-developed-by: for Akash Kumar, Khalid Faisal Ansari, Vishnu Santhosh, Vishnu Saini), the Tested-by: trailer, and the detailed body explaining the board peripherals.

Misleading subject: The PR subject "update Talos Lyra EVK model name" implies the file already exists and only the model string is being updated. In reality, upstream is adding a new board DTS file. The PR cannot "update" a file that doesn't exist yet.

Verdict

Do not merge. This PR is not a faithful representation of the upstream lore patch. It extracts 1 line from a 115-line new-file patch, omits the rest of the file, omits Makefile changes, omits 2 prerequisite patches from the series, misattributes authorship, and misrepresents the scope in the subject and body.

Required corrections:

Include the full patch series (1/3, 2/3, 3/3) or at minimum the complete patch 3/3 (all 120 lines of changes, not just the model string).

Restore original authorship: From: should be Avaneesh Kumar Dwivedi, or if Nirmesh is submitting, Avaneesh's Signed-off-by: must be present.

Fix the subject: Use the upstream subject "arm64: dts: qcom: talos: Add Talos Lyra EVK board" (or adapt to "FROMLIST: arm64: dts: qcom: talos: Add Talos Lyra EVK board").

Restore the full commit body with peripheral descriptions, co-authors, and trailers.

Include Makefile changes (5 lines adding DTB targets).

Final Summary

Lore link present: Yes — https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-3-658fd5a7ec99@oss.qualcomm.com/

Lore link matches PR commits: No — PR contains only 1 line (model string) from a 115-line new-file patch; missing 114 lines of new DTS content, 5 lines of Makefile changes, and 2 prerequisite patches (1/3 dt-bindings, 2/3 SoM DTSI). Authorship is incorrect (missing original author's Signed-off-by). Subject and body misrepresent the scope.

Upstream patch status: ⏳ Decision Pending — posted Oct 27, 2026 (3 days ago). Maintainer Krzysztof Kozlowski replied on Oct 27 requesting clarification on SoM compatible design for patch 1/3 (dt-bindings). No acceptance or rejection signal for patch 3/3 yet. Active review in progress.

PR present in qcom-next/topics: No — integration_presence_report.md confirms 1/1 commit is missing from both qcom-next and topics. This is expected since the upstream series is still under review and has not been merged.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ae2606baf50f01e14ed7ddfa73116e5850c6c0d1
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final

1/1 [PATCH] FROMLIST: arm64: dts: qcom: update Talos Lyra EVK model name missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

qlijarvis · 2026-10-30T12:24:34Z

PR #1368 — checker-log-analyzer

PR: #1368
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41048021640

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	✅	All DTB validations passed
sparse-check	⏭️	Skipped (no C/H file changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	2 failures: content mismatch + author mismatch
tag-check	✅	Subject has valid `FROMLIST:` prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1368 - FROMLIST: arm64: dts: qcom: update Talos Lyra EVK model name
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41048021640
Target branch: qcom-6.18.y

Checker Result Summary

checkpatch ✅ No style issues

dt-binding-check ⏭️ Skipped (no binding changes)

dtb-check ✅ All DTB validations passed

sparse-check ⏭️ Skipped (no C/H file changes)

check-uapi-headers ⏭️ Skipped (no UAPI changes)

check-patch-compliance ❌ 2 failures: content mismatch + author mismatch

tag-check ✅ Subject has valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: The patch content differs from the upstream lore link, and the commit author does not match the original patch author.

Failure details:
Checking commit: FROMLIST: arm64: dts: qcom: update Talos Lyra EVK model name
Change is different from the one mentioned in Link
Author mismatch:
  Original author: Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>
  Commit author : Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>
Analysis:

This PR has two distinct compliance issues:

1. Content mismatch
The patch in the PR differs from the upstream patch at the provided lore link:
https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-3-658fd5a7ec99@oss.qualcomm.com/

The PR changes:
-	model = "Qualcomm QCS615 Talos Lyra EVK";
+	model = "Qualcomm Technologies, Inc. QCS615 Talos Lyra EVK";
To verify if this is a legitimate adaptation or an error, fetch the upstream patch and compare:
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20261027-talos-lyra-evk-v2-v3-3-658fd5a7ec99@oss.qualcomm.com/ -o /tmp/upstream
git format-patch -1 c55716ef7543aa58d6a64e20ea526df81f30a1dd --stdout > /tmp/pr.patch
diff <(awk '/^diff/,/^--$/' /tmp/pr.patch | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/upstream/*.mbx | grep -E '^[+-][^+-]')
Possible scenarios:

If the upstream patch has the same change → this is a false positive (context-only diff shift)

If the upstream patch is different → the PR either:

Cherry-picked the wrong version (v2 vs v3)

Applied additional modifications not in upstream

Referenced the wrong lore link

2. Author mismatch
The commit author in the PR is Nirmesh Kumar Singh <nirmesh.singh@oss.qualcomm.com>, but the original upstream patch author is Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>.

When backporting or cherry-picking upstream patches, the original author must be preserved.

Fix:

For author mismatch:
git rebase -i 4b7f69a1ee2e   # mark commit as 'edit'
git commit --amend --author="Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com>"
git rebase --continue
For content mismatch:

Fetch the upstream patch with b4 (command above)

Compare the diff carefully

If the PR has extra changes not in upstream:

Either remove them and match upstream exactly, OR

Document the adaptation in the commit message with a note like:
[nirmesh: adapted model string to include "Technologies, Inc."]

If the wrong lore link was used, update the Link: tag to point to the correct version

Reproduce locally:
cd /path/to/kernel
git fetch origin qcom-6.18.y
git checkout qcom-6.18.y
git fetch origin pull/1368/head:pr-1368
git checkout pr-1368
../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 4b7f69a1ee2e --head c55716ef7543aa58d6a64e20ea526df81f30a1dd
Verdict

2 blockers must be fixed before merge:

Author mismatch — Change commit author to Avaneesh Kumar Dwivedi <avaneesh.dwivedi@oss.qualcomm.com> (the original upstream author)

Content mismatch — Verify the patch content matches the upstream lore link exactly, or document any intentional adaptations in the commit message

All other checkers passed or were correctly skipped. Once these two issues are resolved, the PR will be ready to merge.

nkumarsi requested review from a team, knaveen-qc, Mukesh Ojha (mukeshojha-linux) and Shiraz Hashim (shashim-quic) October 30, 2026 11:21

Navigation Menu

Repository navigation

FROMLIST: arm64: dts: qcom: update Talos Lyra EVK model name - #1368

FROMLIST: arm64: dts: qcom: update Talos Lyra EVK model name#1368
nkumarsi wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
nkumarsi:talos-lyra-model

nkumarsi commented Oct 30, 2026

Uh oh!

qswat-orbit-external Bot commented Oct 30, 2026

Uh oh!

qswat-orbit-external Bot commented Oct 30, 2026

Uh oh!

qswat-orbit-external Bot commented Oct 30, 2026

Uh oh!

qswat-orbit-external Bot commented Oct 30, 2026

Uh oh!

qlijarvis commented Oct 30, 2026

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Oct 30, 2026

🤖 CI Checker Analysis (checker-log-analyzer)

❌ check-patch-compliance

Verdict

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nkumarsi commented Oct 30, 2026

Uh oh!

qswat-orbit-external Bot commented Oct 30, 2026

Uh oh!

qswat-orbit-external Bot commented Oct 30, 2026

Uh oh!

qswat-orbit-external Bot commented Oct 30, 2026

Uh oh!

qswat-orbit-external Bot commented Oct 30, 2026

Uh oh!

qlijarvis commented Oct 30, 2026

PR #1368 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Diff

Issues

Verdict

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Oct 30, 2026

PR #1368 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ check-patch-compliance

Verdict

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants