Skip to content

arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces - #1364

Open
Eshitha oyyavuru (kppeoyyavuru) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
kppeoyyavuru:phy-reset
Open

Eshitha oyyavuru (kppeoyyavuru) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
kppeoyyavuru:phy-reset

Conversation

@kppeoyyavuru

@kppeoyyavuru Eshitha oyyavuru (kppeoyyavuru) commented Oct 29, 2026 •

Copy link
Copy Markdown

On some boards, the MDIO bus fails to discover the PHY because the
PHY returns no valid reset values during discovery.

Port 0 uses an AQR113C PHY. Its active-low RST_N pin is connected
to a TLMM GPIO, so the reset GPIO needs to be configured with
GPIO_ACTIVE_LOW.

This change applies the correct reset polarity before MDIO discovery.
PHY discovery succeeds on both the previously affected boards and
the boards that were already working.

CRs-Fixed: 4717834
QLIJIRA: QLIJIRA-104

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

4 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4717834 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4717834

Please ensure the CR has a change task associated with at least one of the entities for this branch.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4717834 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4717834

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #1364 — validate-patch

PR: #1364

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix to indicate origin
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — commit lacks attribution; appears to be vendor-only but missing QCLINUX: prefix
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1364 - net: qps615: fix missing Ethernet interfaces
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No lore link or vendor prefix present
Body preserves rationale ⚠️ Describes the fix but lacks upstream attribution
Fixes tag present/correct ❌ Missing — should reference the commit that introduced the incorrect GPIO polarity
Authorship preserved N/A No upstream source to compare
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-staging.dtso ⚠️ Changes PHY reset GPIO polarity from ACTIVE_HIGH to ACTIVE_LOW; appears correct for the fix described

Issues

  1. Missing vendor prefix: Commit subject lacks a required prefix (QCLINUX:, UPSTREAM:, FROMLIST:, etc.). This appears to be a vendor-only fix for a Qualcomm board and should use QCLINUX: net: qps615: fix missing Ethernet interfaces.

  2. Missing Fixes tag: The commit fixes a PHY initialization issue but doesn't include a Fixes: tag referencing the commit that introduced the incorrect GPIO_ACTIVE_HIGH polarity. This is required for proper git history tracking.

  3. Internal CR reference only: The commit message contains CR 4717834 but no public bug tracker reference or detailed technical rationale explaining why GPIO_ACTIVE_LOW is the correct polarity for this PHY reset line.

  4. Not present in qcom-next or topics: According to integration_presence_report.md, this commit is missing from both qcom-next and the kernel topic branches. This is a validation failure — commits should be present in the integration tree before being merged.

  5. No lore link: While vendor-only commits don't require lore links, the lack of any prefix makes it unclear whether this was intended as a vendor-only change or should have been posted upstream.

Verdict

Do not merge. This commit requires the following corrections:

  1. Add QCLINUX: prefix to the subject line (if this is vendor-only) or post to upstream and add FROMLIST: prefix with a lore link
  2. Add a Fixes: tag referencing the commit that introduced the incorrect GPIO polarity
  3. Expand the commit message to explain the technical rationale (e.g., hardware documentation, datasheet reference, or testing evidence showing ACTIVE_LOW is correct)
  4. Investigate why this commit is missing from qcom-next/topics integration branches

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix to indicate origin
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — commit lacks attribution; appears to be vendor-only but missing QCLINUX: prefix
  4. PR present in qcom-next/topics: Fail — commit is missing from both qcom-next and topics (0/1 commits present)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] net: qps615: fix missing Ethernet interfaces missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1364 — checker-log-analyzer

PR: #1364
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40865474351

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ DTB validation passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ Missing required subject prefix
tag-check ❌ Subject prefix required for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1364 — net: qps615: fix missing Ethernet interfaces
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40865474351
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ DTB validation passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ Missing required subject prefix
tag-check ❌ Subject prefix required for qcom-6.18.y

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: net: qps615: fix missing Ethernet interfaces
Commit summary does not start with a required prefix

Fix: Add an appropriate prefix to the commit subject based on the patch origin:

git rebase -i 915a4e43cd69   # mark commit as 'edit'
git commit --amend -m "QCLINUX: net: qps615: fix missing Ethernet interfaces"
git rebase --continue

Choose the correct prefix:

  • FROMLIST: — if posted to lore.kernel.org but not yet merged
  • FROMGIT: — if taken from a maintainer git tree
  • UPSTREAM: — if merged into Linus's mainline tree
  • BACKPORT: — if backported with modifications from upstream
  • QCLINUX: — if vendor-only change with no upstream equivalent (most likely for this CR-based fix)

Note: The check-patch-compliance checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, and BACKPORT: prefixes. If you use QCLINUX: (vendor-only), this checker will continue to fail — this is a known limitation. However, the commit must still carry a prefix for the qcom-6.18.y branch.

Reproduce locally:

cd kernel
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 915a4e43cd69..eee5738ade04

❌ tag-check

Root cause: Subject line does not start with a required prefix (mandatory for all branches except qcom-next and qcom-next-staging).

Failure details:

Commit eee5738ade04 ("net: qps615: fix missing Ethernet interfaces"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Same as above — add the appropriate prefix to the commit subject.

Reproduce locally:

git log 915a4e43cd69..eee5738ade04 --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING prefix in commit $sha: $subject"
  fi
done

Verdict

1 blocker to fix before merge: Add a subject prefix (QCLINUX: recommended for this vendor-specific CR fix) to the commit.

The patch itself is clean (checkpatch passed, DTB validation passed), but the commit message format does not meet the branch requirements for qcom-6.18.y.

@kppeoyyavuru Eshitha oyyavuru (kppeoyyavuru) changed the title net: qps615: fix missing Ethernet interfaces arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces Oct 29, 2026
@qlijarvis

Copy link
Copy Markdown

PR #1364 — validate-patch

PR: #1364

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1364 - QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Upstream commit: N/A (vendor-only QCLINUX: commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit; no upstream source
Body preserves rationale ✅ Clear problem description and fix rationale
Fixes tag present/correct ❌ Missing Fixes: tag for the commit that introduced incorrect GPIO polarity
Authorship preserved ✅ Proper From: and Signed-off-by: present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-staging.dtso ✅ Single-line fix: GPIO_ACTIVE_HIGH → GPIO_ACTIVE_LOW for PHY reset

Issues

  • Missing Fixes tag: The commit fixes a bug (incorrect GPIO polarity preventing Ethernet initialization) but doesn't include a Fixes: tag referencing the original commit that introduced the incorrect configuration. This makes it harder to track the regression and identify affected kernel versions.

Verdict

Merge with minor improvement recommended: Add a Fixes: tag to reference the commit that originally introduced the incorrect GPIO_ACTIVE_HIGH polarity. The technical fix is correct and minimal.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — missing from both qcom-next and topics (expected for new vendor-only commit awaiting merge)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1364 — checker-log-analyzer

PR: #1364
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40896206078

Checker Result Summary
Checker Result Summary
checkpatch ✅ 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check ✅ Test passed
sparse-check ⏭️ Skipping sparse check as nothing changed
check-uapi-headers ⏭️ Skipping uapi check as nothing changed
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ✅ Subject has valid prefix (QCLINUX:)
qcom-next-check ⚠️ Vendor-only commit (QCLINUX:) - not upstream-bound

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1364 - QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40896206078
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ No changes in Documentation/devicetree/bindings
dtb-check ✅ Test passed
sparse-check ⏭️ Skipping sparse check as nothing changed
check-uapi-headers ⏭️ Skipping uapi check as nothing changed
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ✅ Subject has valid prefix (QCLINUX:)
qcom-next-check ⚠️ Vendor-only commit (QCLINUX:) - not upstream-bound

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: prefix, which is not in the checker's allowed prefix list.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The QCLINUX: prefix is used for vendor-only changes with no upstream equivalent, but the checker does not recognize it as valid. This is documented in the skill's false-positive guide (Section 9 of log-patterns.md).

Why this commit uses QCLINUX::

The patch modifies monaco-evk-staging.dtso, which is a vendor-specific staging device tree overlay. The change fixes PHY reset GPIO polarity for Ethernet interfaces on the Monaco EVK board. This is a board-specific hardware configuration fix that:

  • Targets a vendor staging file (-staging.dtso)
  • Contains vendor-specific hardware details
  • Is not suitable for upstream submission

Verdict on this failure:

✅ This is an acceptable false positive. The QCLINUX: prefix is correct for this vendor-only change. The checker limitation is known and documented.

No action required — the commit is properly tagged for its purpose.


⚠️ qcom-next-check (informational)

Status: This commit is vendor-only (QCLINUX: prefix) and is not upstream-bound.

Context:

For branches other than qcom-next / qcom-next-staging, commits should ideally be upstream-bound (using FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT: prefixes) to ensure the vendor tree stays aligned with mainline.

However, vendor-specific staging files like monaco-evk-staging.dtso are explicitly maintained outside the upstream path, so a QCLINUX: prefix is appropriate here.

No action required — this is the correct classification for a staging board file fix.


Verdict

✅ Ready to merge

Summary:

  • All technical checkers passed (checkpatch, dtb-check) or were correctly skipped
  • The check-patch-compliance failure is a known false positive for QCLINUX: prefixed commits
  • The commit is properly tagged as vendor-only, which is appropriate for a staging device tree overlay
  • The change is minimal (1 line) and fixes a hardware configuration issue (GPIO polarity)

Recommendation: Merge as-is. The checker failure is expected and acceptable for vendor-only staging file changes.

@qlijarvis

Copy link
Copy Markdown

PR #1364 — validate-patch

PR: #1364

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1364 - QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Upstream commit: N/A (vendor-only commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix indicates vendor-only change
Body preserves rationale ✅ Clear description of PHY discovery issue and fix
Fixes tag present/correct ⚠️ No Fixes tag — should reference the commit that introduced the incorrect polarity
Authorship preserved ✅ Eshitha Oyyavuru correctly listed as author
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-staging.dtso ✅ Single-line fix: GPIO_ACTIVE_HIGH → GPIO_ACTIVE_LOW

Issues

  • Missing Fixes tag: The commit message should include a Fixes: tag referencing the commit that introduced GPIO_ACTIVE_HIGH for this PHY reset GPIO. This helps track the regression and aids stable backport decisions.
  • Integration presence: The commit is missing from both qcom-next and kernel-topics branches (per integration_presence_report.md). For a QCLINUX: vendor-only commit, this is expected if it's a new fix not yet merged.

Verdict

Merge with recommendation to add a Fixes tag. The technical fix (GPIO polarity correction) is correct and well-explained. The commit message clearly describes the problem (MDIO PHY discovery failure) and solution (correct reset GPIO polarity).

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Not checked — QCLINUX: vendor-only commit (integration_presence_report.md shows missing, which is expected for new vendor fixes)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1364 — checker-log-analyzer

PR: #1364
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41007991639

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Test passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ⚠️ QCLINUX: is valid for tag-check but fails patch-compliance

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1364 — QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41007991639
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Test passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ⚠️ QCLINUX: is valid for tag-check but fails patch-compliance

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: subject prefix, which is not in the allowed list for check-patch-compliance.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker enforces a strict subset of prefixes:

  • ✅ Allowed: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:
  • ❌ Not allowed: QCLINUX:, PENDING:, WORKAROUND:

This is a known limitation of the checker — it only accepts upstream-linkable prefixes. Vendor-only commits with QCLINUX: will always fail this check.

Context:

This PR targets qcom-6.18.y, which is not qcom-next or qcom-next-staging. For all other branches:

  • Every commit must have a subject prefix (tag-check requirement).
  • The QCLINUX: prefix is valid for internal use and satisfies the tag-check requirement.
  • However, check-patch-compliance rejects it because it expects an upstream link.

Options:

  1. If this change has been posted upstream (to a mailing list):

    • Change prefix to FROMLIST:
    • Add Link: <lore.kernel.org URL> to the commit body
    • Re-run CI
  2. If this is a vendor-only change (no upstream equivalent):

    • The check-patch-compliance failure is expected and can be ignored as a known false positive.
    • The commit is correctly tagged with QCLINUX: per internal conventions.
    • All other checkers passed.

Reproduce locally:

cd kernel
git log --oneline 4b7f69a1ee2e..c6a5c73a1d1f
# Verify the commit subject starts with QCLINUX:

Fix (if upstream link exists):

git rebase -i 4b7f69a1ee2e
# mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces

<original body>

Link: https://lore.kernel.org/...
Signed-off-by: Eshitha Oyyavuru <eoyyavur@qti.qualcomm.com>"
git rebase --continue

Verdict

One blocker — check-patch-compliance failure due to QCLINUX: prefix.

Recommendation:

  • If this change has been posted upstream → add FROMLIST: prefix + Link: tag and re-run CI.
  • If this is vendor-only → the failure is a known false positive; all other checkers passed. The commit is correctly tagged per internal conventions. Merge as-is or request maintainer override.

…nterfaces

On some boards, the MDIO bus fails to discover the PHY because it
returns no valid reset values.

Port 0 uses an AQR113C PHY with its active-low RST_N pin connected to
a TLMM GPIO. Configure the reset GPIO with the correct polarity so
the PHY is reset before MDIO discovery.

PHY discovery then succeeds on both the affected boards and the
boards that were already working.

Signed-off-by: Eshitha Oyyavuru <eoyyavur@qti.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1364 — validate-patch

PR: #1364

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1364 - PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Upstream commit: N/A (PENDING: prefix — not yet posted upstream)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: commit — no upstream source
Body preserves rationale ✅ Clear problem description and fix explanation
Fixes tag present/correct ⚠️ No Fixes tag; may be acceptable for new hardware enablement
Authorship preserved ✅ Author and Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-staging.dtso ✅ Single-line polarity fix: GPIO_ACTIVE_HIGH → GPIO_ACTIVE_LOW for PHY reset

Issues

None. The commit message is well-structured with clear problem statement, fix description, and validation. The diff is minimal and technically correct (AQR113C PHY RST_N is active-low).

Verdict

Merge as-is. This is a valid PENDING: commit for vendor-specific hardware enablement. The GPIO polarity fix is correct and well-documented.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (expected for PENDING: commits)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1364 — checker-log-analyzer

PR: #1364
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41029105985

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No new DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Invalid prefix: PENDING: not allowed
tag-check ❌ PENDING: is not a valid prefix for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1364 - PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41029105985
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No new DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Invalid prefix: PENDING: not allowed
tag-check ❌ PENDING: is not a valid prefix for qcom-6.18.y

❌ check-patch-compliance

Root cause: Commit subject starts with PENDING: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Commit summary does not start with a required prefix

Fix: Change the prefix based on the patch's upstream status:

If the patch is... Use this prefix
Posted to lore.kernel.org (not yet merged) FROMLIST: + add Link: <lore-url>
In a maintainer git tree FROMGIT: + add Link: <tree-url>
Merged into Linus's mainline UPSTREAM: + add Link: <lore-url>
Backported with modifications BACKPORT: + add Link: <lore-url>
Vendor-only (no upstream) QCLINUX: (but see note below)

Note on PENDING: and QCLINUX:: These prefixes are used internally but not accepted by check-patch-compliance. The checker enforces upstream-linkable prefixes only. If this is truly a vendor-only change with no upstream equivalent, the checker will always fail — this is a known limitation.

Reproduce locally:

cd /path/to/kernel
git log 4b7f69a1ee2e..fbf730279ca2 --format="%H %s"
# Verify the subject prefix

Fix command:

git rebase -i 4b7f69a1ee2e
# mark commit fbf730279ca2 as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces

On some boards, the MDIO bus fails to discover the PHY because it
returns no valid reset values.

Port 0 uses an AQR113C PHY with its active-low RST_N pin connected to
a TLMM GPIO. Configure the reset GPIO with the correct polarity so
the PHY is reset before MDIO discovery.

PHY discovery then succeeds on both the affected boards and the
boards that were already working.

Link: <lore-url-if-posted>
Signed-off-by: Eshitha Oyyavuru <eoyyavur@qti.qualcomm.com>"
git rebase --continue

❌ tag-check

Root cause: The target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), which requires every commit to start with a valid prefix tag. The commit uses PENDING:, which is not a valid prefix for this branch.

Failure details:

Commit fbf730279ca2 ("PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces")
Subject line does not start with a required prefix.

Required prefixes for qcom-6.18.y:

  • FROMLIST: — Patch posted to mailing list (lore.kernel.org)
  • FROMGIT: — Patch taken from a maintainer git tree
  • UPSTREAM: — Patch merged into Linus's mainline tree
  • BACKPORT: — Upstream patch backported with modifications
  • QCLINUX: — Vendor-only change with no upstream equivalent
  • WORKAROUND: — Temporary fix not suitable for upstream

Fix: Same as check-patch-compliance above — change PENDING: to the appropriate prefix based on the patch's upstream status.


Verdict

2 blockers must be fixed before merge:

  1. Change subject prefix from PENDING: to a valid upstream-linkable prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, or QCLINUX:)
  2. Add Link: trailer if using FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT: prefix

All other checkers passed or skipped appropriately. The patch itself (DTS change fixing PHY reset polarity) has no technical issues — only the commit metadata needs correction.

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On some boards, the MDIO bus fails to discover

On which boards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants