[tapas-rana2811]

…amp control

CRs-fixed: 4673342

x1e80100_usb3dpphy_cfg uses qmp_v6_n4_usb3phy_regs_layout for .regs, which maps QPHY_PCS_CLAMP_ENABLE to QPHY_V6_PCS_AON_CLAMP_ENABLE, expecting the clamp-enable bit in the pcs_aon region. But its .offsets points to qmp_combo_offsets_v5, which has no usb3_pcs_aon member, so qmp->pcs_aon is never mapped. This forces qmp_combo_enable/disable_autonomous_mode() to fall back to pcs_misc and write the AON clamp offset there instead, so the I/O clamp is not correctly controlled during USB autonomous mode.

Add qmp_combo_offsets_v6, identical to qmp_combo_offsets_v5 but with usb3_pcs_aon = 0x0100 set, and point x1e80100_usb3dpphy_cfg.offsets at it instead.

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4673342 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4673342

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qlijarvis]

PR #1357 — validate-patch

PR: #1357

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix (QCLINUX:/PENDING:/WORKAROUND:) to indicate this is vendor-only
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Unknown — cannot determine without lore link; commit has no prefix indicating upstream status
4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1357 - phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	❌	No upstream link to compare against
Body preserves rationale	❌	No upstream source to verify
Fixes tag present/correct	❌	Missing Fixes tag for bug fix
Authorship preserved	N/A	No upstream source
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/phy/qualcomm/phy-qcom-qmp-combo.c	⚠️	Cannot verify against upstream - no lore link

Issues

Critical:

1. No lore.kernel.org link found — This commit has no vendor prefix (QCLINUX:, PENDING:, WORKAROUND:) and no Link: tag pointing to lore.kernel.org. Bug fixes for upstream drivers must include either:

   • UPSTREAM: prefix + link to the merged kernel.org commit, OR
   • FROMLIST: prefix + link to the lore.kernel.org posting, OR
   • BACKPORT: prefix + link to the original upstream commit

2. Missing Fixes tag — This commit fixes a bug in the X1E80100 USB3/DP PHY configuration (incorrect offsets table causing PCS_AON clamp control to fail). It should include a Fixes: tag referencing the commit that introduced x1e80100_usb3dpphy_cfg or the incorrect offsets assignment.

3. Commit prefix missing — The subject line has no prefix indicating the upstream status of this patch. Based on the content (fixing a driver bug for an upstream platform), this should be either:

   • FROMLIST: if posted to the mailing list but not yet merged
   • UPSTREAM: if already merged into Linus's tree or a maintainer tree
   • QCLINUX: only if this is a vendor-specific workaround not suitable for upstream

Verdict

Do not merge without correction. This commit lacks the required upstream attribution. The fix appears legitimate and should be upstreamed if not already posted. Required actions:

1. Determine if this patch has been posted to linux-phy@lists.infradead.org or linux-arm-msm@vger.kernel.org
2. If posted: add FROMLIST: prefix and Link: https://lore.kernel.org/r/<message-id> tag
3. If merged upstream: add UPSTREAM: prefix and link to the kernel.org commit
4. If not yet posted: either post it upstream first, or use QCLINUX: prefix if it's vendor-only
5. Add a Fixes: tag identifying the commit that introduced the bug

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message; no vendor prefix (QCLINUX:/PENDING:/WORKAROUND:) to indicate this is vendor-only
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Unknown — cannot determine without lore link; commit has no prefix indicating upstream status
4. PR present in qcom-next/topics: Yes — commit is present in qcom-next (per integration_presence_report.md: "all checked added lines are present")

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable	present - all checked added lines are present	skipped - not checked because qcom-next already contains the change	present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 0/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

[qlijarvis]

PR #1357 — checker-log-analyzer

PR: #1357
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40691212879

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No binding changes
dtb-check	⏭️	No DTS changes
sparse-check	✅	No static analysis issues
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing subject prefix
tag-check	❌	Missing subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1357 - phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40691212879
Target branch: qcom-6.18.y

Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	⏭️	No binding changes
dtb-check	⏭️	No DTS changes
sparse-check	✅	No static analysis issues
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing subject prefix
tag-check	❌	Missing subject prefix (mandatory for qcom-6.18.y)

---

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

Checking commit: phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control
Commit summary does not start with a required prefix

Fix: Add an appropriate prefix to the commit subject. Since this appears to be a bug fix for the X1E80100 PHY driver, you should determine the patch origin:

1. If this patch was posted to lore.kernel.org (mailing list):

   git commit --amend -m "FROMLIST: phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control"

   Then add a Link: tag in the commit body pointing to the lore URL.

2. If this patch is already merged in Linus's mainline tree:

   git commit --amend -m "UPSTREAM: phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control"

   Add a Link: tag pointing to the lore URL and optionally a commit <sha> upstream reference.

3. If this patch is in a maintainer's git tree (e.g., linux-phy.git):

   git commit --amend -m "FROMGIT: phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control"

   Add a Link: tag and reference the maintainer tree.

4. If this is a vendor-only fix with no upstream equivalent:

   git commit --amend -m "QCLINUX: phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control"

   Note: QCLINUX: will still fail check-patch-compliance (known limitation), but satisfies the tag-check requirement.

Reproduce locally:

cd kernel
./scripts/check-patch-compliance.sh <base_sha> <head_sha>

---

❌ tag-check

Root cause: Target branch qcom-6.18.y requires all commits to have a subject prefix tag.

Failure details:

Commit 87252652954badab992ad47f00c6355ce4c71770
Subject: phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control

The subject line does not start with any of the required prefixes:

• FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Same as above — add the appropriate prefix based on the patch origin. The tag-check applies to all branches except qcom-next and qcom-next-staging. Since this PR targets qcom-6.18.y, the prefix is mandatory.

Reproduce locally:

git log --format="%H %s" <base>..<head> | grep -vE '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'

---

Verdict

2 blockers must be fixed before merge:

1. Add subject prefix — Choose the correct prefix based on patch origin (FROMLIST:, UPSTREAM:, FROMGIT:, or QCLINUX:)
2. Add Link: tag — If the patch has an upstream equivalent, add Link: <lore-url> to the commit body

Recommended action:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "FROMLIST: phy: qcom: qmp-combo: Fix X1E80100 offsets table to enable PCS_AON clamp control"
# Edit commit message to add Link: tag in the body
git rebase --continue
git push --force-with-lease

Once the prefix and Link are added, re-trigger CI. All other checkers passed cleanly.