Repository navigation
FROMLIST: arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity - #2168
Open
Zhiyuan Sheng (szy9704) wants to merge 1 commit into
Open
Zhiyuan Sheng (szy9704) wants to merge 1 commit into
Zhiyuan Sheng (szy9704) wants to merge 1 commit into
Conversation
The W_DISABLE2# signal of the M.2 E key connector is active-low as defined in the PCI Express M.2 Specification. Fix the w-disable2-gpios polarity by using GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH. Fixes: 073c6a8 ("arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector") Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com> Link: https://lore.kernel.org/r/20261030030906.3856759-1-zhiyuan.sheng@oss.qualcomm.com Signed-off-by: Zhiyuan Sheng <zhiyuan.sheng@oss.qualcomm.com>
Shiraz Hashim (shashim-quic)
approved these changes
Oct 31, 2026
Shiraz Hashim (shashim-quic)
requested a review
from Srinivas Kandagatla (Srinivas-Kandagatla)
October 31, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The W_DISABLE2# signal of the M.2 E key connector is active-low as defined in the PCI Express M.2 Specification. Fix the w-disable2-gpios polarity by using GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH.
Fixes: 073c6a8 ("arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector")
Reviewed-by: Konrad Dybcio konrad.dybcio@oss.qualcomm.com
Reviewed-by: Abel Vesa abel.vesa@oss.qualcomm.com
Upstream link: https://lore.kernel.org/r/20261030030906.3856759-1-zhiyuan.sheng@oss.qualcomm.com/
CRs-Fixed: 4728838