Skip to content

arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces - #2161

Open
Eshitha oyyavuru (kppeoyyavuru) wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
kppeoyyavuru:monaco-phy-reset
Open

Eshitha oyyavuru (kppeoyyavuru) wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
kppeoyyavuru:monaco-phy-reset

Conversation

@kppeoyyavuru

@kppeoyyavuru Eshitha oyyavuru (kppeoyyavuru) commented Oct 29, 2026 •

Copy link
Copy Markdown

On some boards, the MDIO bus fails to discover the PHY because the
PHY returns no valid reset values during discovery.

Port 0 uses an AQR113C PHY. Its active-low RST_N pin is connected
to a TLMM GPIO, so the reset GPIO needs to be configured with
GPIO_ACTIVE_LOW.

This change applies the correct reset polarity before MDIO discovery.
PHY discovery succeeds on both the previously affected boards and
the boards that were already working.

CRs-Fixed: 4717834

QLIJIRA: QLIJIRA-104

@qswat-orbit-external

Copy link
Copy Markdown

Dev Completion validation failed

CR: 4717834
Change Task: kernel.qli.0.0
Error: GenAI Assisted field must be set before moving change tasks to Development Complete. Please provide GenAI information.

The change task for this CR could not be moved to Dev Complete because of the error above. Please resolve the issue in Orbit and re-run the failed Orbit check.

@qcomlnxci
qcomlnxci requested review from a team, Amit Kucheria (idlethread), jingyiwang42 and yijiyang and removed request for a team October 29, 2026 12:03
@qlijarvis

Copy link
Copy Markdown

PR #2161 — validate-patch

PR: #2161

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found; vendor-specific change should have QCLINUX: prefix to indicate no upstream equivalent expected
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific device tree staging overlay change; not posted upstream and not expected to be
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #2161 — net: qps615: fix missing Ethernet interfaces
Upstream commit: N/A (vendor-specific device tree fix)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No upstream source; vendor-specific fix
Body preserves rationale ⚠️ Brief description; could explain root cause more clearly
Fixes tag present/correct N/A No upstream commit to reference
Authorship preserved ✅ Proper Signed-off-by present
Backport note (if applicable) N/A Not a backport
Vendor prefix required ❌ Missing QCLINUX: prefix in subject line

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-staging.dtso ✅ Clean single-line fix: GPIO polarity correction for PHY reset

Issues

  1. ❌ Missing vendor prefix — The subject line lacks a QCLINUX: prefix. Since this changes a vendor-specific staging device tree overlay (monaco-evk-staging.dtso) and has no upstream lore link, it should be prefixed with QCLINUX: to clearly indicate it's a vendor-only change.

    Expected subject:
    QCLINUX: net: qps615: fix missing Ethernet interfaces

  2. ⚠️ Commit message could be more detailed — While the description mentions "PHY initialization issue," it could explain why the polarity was wrong (e.g., "Hardware schematic shows PHY reset is active-low, but DT incorrectly configured it as active-high, preventing proper PHY initialization").

  3. ⚠️ Not present in qcom-next or topics — According to integration_presence_report.md, this commit is missing from both qcom-next and all topic branches. This is expected for a new fix, but should be tracked for integration.

Verdict

Do not merge without correction. The commit must be amended to add the QCLINUX: prefix to the subject line. The technical change itself (GPIO polarity fix) is correct and focused.

Required action:

git commit --amend
# Change subject from:
#   net: qps615: fix missing Ethernet interfaces
# To:
#   QCLINUX: net: qps615: fix missing Ethernet interfaces

Final Summary

  1. Lore link present: No — no lore.kernel.org link found; vendor-specific change should have QCLINUX: prefix to indicate no upstream equivalent expected
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific device tree staging overlay change; not posted upstream and not expected to be
  4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and topics (per integration_presence_report.md); expected for new vendor fix but should be tracked for integration

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] net: qps615: fix missing Ethernet interfaces missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #2161 — checker-log-analyzer

PR: #2161
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40870086549

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ DTB validation passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Missing required subject prefix
tag-check ❌ Subject prefix required (target: tech/overlay/dt)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #2161 - net: qps615: fix missing Ethernet interfaces
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40870086549

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ DTB validation passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ Missing required subject prefix
tag-check ❌ Subject prefix required (target: tech/overlay/dt)

❌ check-patch-compliance

Root cause: Commit subject line does not start with a required prefix tag.

Failure details:

Checking commit: net: qps615: fix missing Ethernet interfaces
Commit summary does not start with a required prefix

The commit subject net: qps615: fix missing Ethernet interfaces lacks a mandatory prefix. The check-patch-compliance checker requires all commits to start with one of: FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:.

Fix:

  1. Determine the correct prefix based on the patch origin:

    • If posted to lore.kernel.org but not yet merged → FROMLIST:
    • If taken from a maintainer git tree → FROMGIT:
    • If merged into Linus's mainline tree → UPSTREAM:
    • If backported with modifications → BACKPORT:
    • If vendor-only with no upstream → QCLINUX: (note: this will still fail the checker, known limitation)
  2. Amend the commit:

    git rebase -i <base_sha>   # mark commit as 'edit'
    git commit --amend -m "FROMLIST: net: qps615: fix missing Ethernet interfaces"
    # (keep the rest of the commit body unchanged)
    git rebase --continue
  3. If this is an upstream patch, also add a Link: trailer pointing to the lore.kernel.org URL in the commit body.

Reproduce locally:

cd <kernel-tree>
git log --oneline <base>..<head>
# Verify subject starts with FROMLIST:/FROMGIT:/UPSTREAM:/BACKPORT:

❌ tag-check

Root cause: Target branch tech/overlay/dt requires subject prefix tags on all commits.

Failure details:

The PR targets branch tech/overlay/dt (not qcom-next or qcom-next-staging), which mandates that every commit subject must start with one of the following prefix tags:

  • FROMLIST: — Patch posted to mailing list (lore.kernel.org)
  • FROMGIT: — Patch taken from a maintainer git tree
  • UPSTREAM: — Patch merged into Linus's mainline tree
  • BACKPORT: — Upstream patch backported with modifications
  • QCLINUX: — Vendor-only change with no upstream equivalent
  • PENDING: — Work-in-progress, not yet posted upstream
  • WORKAROUND: — Temporary fix not suitable for upstream

The commit 577a428 ("net: qps615: fix missing Ethernet interfaces") has no prefix.

Fix:

Choose the appropriate prefix based on the patch's upstream status and amend the commit:

git rebase -i <base_sha>   # mark the commit as 'edit'
git commit --amend -m "QCLINUX: net: qps615: fix missing Ethernet interfaces"
# (or use FROMLIST:/UPSTREAM:/etc. as appropriate)
git rebase --continue

Note: If you use QCLINUX: or PENDING:, the check-patch-compliance checker will still fail (known limitation for vendor-only commits). For upstream-bound patches, use FROMLIST: and add a Link: trailer.

Reproduce locally:

git log <base>..<head> --format="%H %s" | grep -vE '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'
# Any output indicates commits missing a prefix

Verdict

2 blockers must be fixed before merge:

  1. Add subject prefix — The commit subject must start with a valid prefix tag (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:).
  2. Add Link trailer (if upstream) — If this patch is posted upstream or derived from upstream, add a Link: <lore-url> trailer to the commit body.

The technical change itself (GPIO polarity fix for PHY reset) is valid and passes all code quality checks (checkpatch, dtb-check). Only the commit metadata needs correction.

@kppeoyyavuru Eshitha oyyavuru (kppeoyyavuru) changed the title net: qps615: fix missing Ethernet interfaces arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces Oct 29, 2026
@qcomlnxci
qcomlnxci requested a review from a team October 29, 2026 14:52
@qlijarvis

Copy link
Copy Markdown

PR #2161 — validate-patch

PR: #2161

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #2161 — QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Upstream commit: N/A (vendor-only commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit; no upstream source
Body preserves rationale ✅ Clear description of PHY initialization issue
Fixes tag present/correct N/A Not applicable for vendor-only fix
Authorship preserved ✅ Correct author and Signed-off-by
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-staging.dtso ✅ Clean GPIO polarity fix (ACTIVE_HIGH → ACTIVE_LOW)

Issues

  • Integration presence: Commit is missing from both qcom-next and kernel-topics branches. For a vendor-only commit, it should typically be present in at least one integration branch before PR merge.

Verdict

The patch itself is technically correct — it fixes a GPIO polarity issue that prevented Ethernet device registration. However, the commit is not yet present in qcom-next or any kernel-topics branch, which may indicate it needs to land in an integration branch first.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #2161 — checker-log-analyzer

PR: #2161
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40895780292

Checker Result Summary
Checker Result Summary
checkpatch ✅ Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ Passed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check N/A Not required for qcom-next target

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #2161 - QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40895780292
Target branch: qcom-next

Checker Result Summary
checkpatch ✅ Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ Passed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check N/A Not required for qcom-next target

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: subject prefix, which is not in the checker's allowed list of upstream-linkable prefixes.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The checker only accepts the following prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The QCLINUX: prefix is a vendor-internal tag used for Qualcomm-specific changes that have no upstream equivalent. While this prefix is valid and commonly used in the qualcomm-linux/kernel-topics tree, the check-patch-compliance checker does not recognize it.

Why this happens:

The commit subject is:

QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces

This is a vendor-specific devicetree change for the monaco-evk-staging.dtso overlay file. The change fixes a PHY reset GPIO polarity issue (GPIO_ACTIVE_HIGH → GPIO_ACTIVE_LOW). This type of board-specific fix is not suitable for upstream submission, hence the QCLINUX: prefix is appropriate.

Fix options:

  1. No action required (recommended): Since this PR targets qcom-next, and the change is genuinely vendor-specific (staging overlay file), the QCLINUX: prefix is correct. The checker failure is expected and can be ignored. This is a known limitation documented in the skill references.

  2. If upstream submission is planned: If this fix will eventually be posted upstream (unlikely for a staging overlay), change the prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org thread. However, this does not apply here since monaco-evk-staging.dtso is a vendor-specific overlay.

Reproduce locally:

cd kernel
git log --oneline da46baa..ebc02e4
# Verify the commit subject starts with QCLINUX:

Note: The tag-check (subject prefix validation) does not apply to this PR because the target branch is qcom-next. The tag-check is only mandatory for branches other than qcom-next and qcom-next-staging.


Verdict

The PR is ready to merge despite the check-patch-compliance failure.

The check-patch-compliance failure is a false positive caused by the checker's limitation in recognizing vendor-specific prefixes. All other checkers passed or were correctly skipped:

  • ✅ checkpatch — No coding style issues
  • ✅ dtb-check — DTB validation passed
  • ⏭️ dt-binding-check, sparse-check, check-uapi-headers — Correctly skipped (no relevant changes)

The commit itself is valid:

  • Uses the correct QCLINUX: prefix for vendor-specific changes
  • Targets a staging overlay file (monaco-evk-staging.dtso)
  • Fixes a legitimate PHY initialization issue (GPIO polarity)
  • Has proper sign-off and CR reference

Recommendation: Merge as-is. The check-patch-compliance failure is expected for QCLINUX:-prefixed commits and does not indicate a defect in the patch.

@qlijarvis

Copy link
Copy Markdown

PR #2161 — validate-patch

PR: #2161

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #2161 - QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Upstream commit: N/A (vendor-only QCLINUX: commit)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit, no upstream source
Body preserves rationale ✅ Clear problem description and fix rationale
Fixes tag present/correct N/A New staging board support, no Fixes tag needed
Authorship preserved ✅ Proper author and Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-staging.dtso ✅ Single-line GPIO polarity fix, technically correct for active-low RST_N pin

Issues

None. The commit is well-formed for a vendor-only change.

Verdict

Merge as-is. This is a valid vendor-only fix for a staging board configuration. The GPIO polarity correction is technically sound and the commit message clearly explains the problem and solution.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and topics (expected for new PR)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #2161 — checker-log-analyzer

PR: #2161
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41008014267

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ✅ Subject has valid prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #2161 - QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41008014267
Target branch: tech/overlay/dt (qualcomm-linux/kernel-topics)

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ✅ Subject has valid prefix

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: prefix, which is not in the checker's allowed list.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The QCLINUX: prefix is used for vendor-only changes with no upstream equivalent, but the checker does not recognize it as valid. This is documented in the skill's false-positive guide (Section 9 of log-patterns.md).

Important context:

  • The commit does have a valid subject-line prefix tag (QCLINUX:), which satisfies the tag-check requirement for branches other than qcom-next/qcom-next-staging.
  • The check-patch-compliance checker enforces a stricter subset of prefixes and will always fail for QCLINUX:, PENDING:, and WORKAROUND: commits.
  • This is a vendor-only DTS fix (GPIO polarity correction) with no upstream equivalent, so QCLINUX: is the appropriate prefix.

Options:

  1. Accept the failure — This is a known checker limitation for vendor-only commits. The commit is properly tagged with QCLINUX: and passes all other checks.

  2. Add a Link: trailer — If this change was inspired by or related to any upstream discussion/patch, add a Link: trailer pointing to it. However, if this is purely vendor-specific, no such link exists.

  3. Change prefix to FROMLIST: — Only if you plan to post this patch upstream to the devicetree mailing list. This would require:

    • Posting the patch to devicetree@vger.kernel.org and linux-arm-msm@vger.kernel.org
    • Adding Link: <lore-url> to the commit message
    • Changing the subject prefix from QCLINUX: to FROMLIST:

Reproduce locally:

cd kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base 844ad0f2adc371f04c66182e33fe9568bd91ab7c \
  --head 23bbdf6ca0e23677c609950013efb90dacbea902

Verdict

One known checker limitation — the check-patch-compliance failure is expected for vendor-only commits using the QCLINUX: prefix.

Recommendation: Merge as-is if this is a vendor-only fix. All functional checkers (checkpatch, dtb-check) passed cleanly. The check-patch-compliance failure is a known limitation for QCLINUX:-prefixed commits and does not indicate a defect in the patch.

If you want to eliminate the CI failure, consider posting this fix upstream (if appropriate) and changing the prefix to FROMLIST: with a Link: trailer.

…nterfaces

On some boards, the MDIO bus fails to discover the PHY because it
returns no valid reset values.

Port 0 uses an AQR113C PHY with its active-low RST_N pin connected to
a TLMM GPIO. Configure the reset GPIO with the correct polarity so
the PHY is reset before MDIO discovery.

PHY discovery then succeeds on both the affected boards and the
boards that were already working.

Signed-off-by: Eshitha Oyyavuru <eoyyavur@qti.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #2161 — validate-patch

PR: #2161

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required for work-in-progress commits
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — PENDING: prefix indicates work-in-progress, not yet posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #2161 - PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Upstream commit: N/A (PENDING: prefix indicates work-in-progress, not yet posted)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix - no upstream source to compare
Body preserves rationale ✅ Clear description of PHY reset polarity fix
Fixes tag present/correct ⚠️ Missing - should reference the commit that introduced the incorrect polarity
Authorship preserved ✅ Author: Eshitha Oyyavuru eoyyavur@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-staging.dtso ✅ Single-line fix: GPIO_ACTIVE_HIGH → GPIO_ACTIVE_LOW for phy-reset-gpios

Issues

  • Missing Fixes tag: The commit message should include a Fixes: tag referencing the commit that introduced the incorrect GPIO_ACTIVE_HIGH polarity. This is important for tracking the regression and for potential backporting.
  • PENDING prefix usage: The file being modified (monaco-evk-staging.dtso) suggests this is a staging/vendor-specific device tree overlay. If this file is vendor-only and not intended for upstream submission, the PENDING: prefix is appropriate. However, if this fix should eventually be posted upstream, the prefix should be changed to FROMLIST: once posted, then UPSTREAM: or BACKPORT: once merged.

Verdict

The patch is technically correct (fixes PHY reset polarity), but lacks a Fixes: tag for proper commit attribution. The PENDING: prefix is acceptable for work-in-progress changes, but the commit should be tracked for eventual upstream submission if the device tree file is intended for mainline.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required for work-in-progress commits
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — PENDING: prefix indicates work-in-progress, not yet posted upstream
  4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #2161 — checker-log-analyzer

PR: #2161
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41028948172

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ Passed (warnings are pre-existing)
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ✅ PENDING: is a valid subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #2161 - PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41028948172

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ Passed (warnings are pre-existing)
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ✅ PENDING: is a valid subject prefix

❌ check-patch-compliance

Root cause: The commit uses PENDING: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces
Commit summary does not start with a required prefix
##[error]Process completed with exit code 1.

Analysis:
This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). The PENDING: prefix is used in the Qualcomm Linux kernel tree for work-in-progress commits that have not yet been posted upstream, but the checker does not recognize it as valid.

Context:

  • The file being modified (monaco-evk-staging.dtso) is a staging device tree overlay, suggesting this is vendor-specific work.
  • The commit fixes a PHY reset GPIO polarity issue (GPIO_ACTIVE_HIGH → GPIO_ACTIVE_LOW).
  • This is a legitimate use of PENDING: for a work-in-progress fix that may not have an upstream equivalent yet.

Options:

  1. Accept the checker failure (Recommended for vendor-only changes)

    • If this fix is specific to the staging overlay and not intended for upstream submission, the PENDING: prefix is correct.
    • The checker will always fail for PENDING: commits — this is expected behavior.
    • No action needed; merge with the understanding that this checker limitation is known.
  2. Change prefix to FROMLIST: if posted upstream

    • If this fix has been or will be posted to a mailing list, change the prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL.
    • This will satisfy the checker.
  3. Change prefix to QCLINUX: for vendor-only work

    • If this is purely vendor-specific and will never be posted upstream, you could use QCLINUX: instead.
    • However, QCLINUX: also fails check-patch-compliance (same limitation), so this doesn't solve the checker failure.

Reproduce locally:

# The checker script validates prefixes against this regex:
# ^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT):
# PENDING: does not match, so it fails.

Fix (if changing to FROMLIST:):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: monaco-evk-staging: fix missing Ethernet interfaces

On some boards, the MDIO bus fails to discover the PHY because it
returns no valid reset values.

Port 0 uses an AQR113C PHY with its active-low RST_N pin connected to
a TLMM GPIO. Configure the reset GPIO with the correct polarity so
the PHY is reset before MDIO discovery.

PHY discovery then succeeds on both the affected boards and the
boards that were already working.

Link: https://lore.kernel.org/...  # Add actual lore link
Signed-off-by: Eshitha Oyyavuru <eoyyavur@qti.qualcomm.com>"
git rebase --continue

Verdict

1 checker failure due to known limitation.

The check-patch-compliance failure is a known checker limitation for PENDING: prefixed commits. All other checkers passed or were correctly skipped.

Recommendation:

  • If this is vendor-only work: Merge as-is. The PENDING: prefix is correct, and the checker failure is expected.
  • If this will be posted upstream: Change prefix to FROMLIST: and add a Link: tag, then re-run CI.
  • Additional improvement: Consider adding a Fixes: tag to reference the commit that introduced the incorrect GPIO polarity.

The technical change itself (GPIO_ACTIVE_HIGH → GPIO_ACTIVE_LOW) is correct and addresses a real PHY discovery issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants