Skip to content

FROMLIST: arm64: dts: qcom: glymur-crd: Mark L4C regulator as boot-on to save power - #2029

Open
QUIC-kamalw wants to merge 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
QUIC-kamalw:tech/all/dt/glymur
Open

QUIC-kamalw wants to merge 1 commit into
qualcomm-linux:tech/all/dt/glymurfrom
QUIC-kamalw:tech/all/dt/glymur

Conversation

@QUIC-kamalw

@QUIC-kamalw QUIC-kamalw commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

On current Glymur Rev-1 boards, the third USB controller and PHY are not enabled, so the L4C regulator has no active consumers. The regulator node cannot be removed, however, since Rev-2 boards will enable the corresponding USB hardware.

This rail may have been left enabled by the bootloader. The RPMH regulator driver cannot query real hardware state, so without regulator-boot-on the core assumes the rail is already off and never issues an explicit disable during late cleanup, leaving it enabled indefinitely while unused.

Add regulator-boot-on so the core knows to explicitly disable the rail during late cleanup when no consumers are present.

Reviewed-by: Abel Vesa abel.vesa@oss.qualcomm.com
Signed-off-by: Kamal Wadhwa kamal.wadhwa@oss.qualcomm.com
Link: https://lore.kernel.org/all/20261009-b4-regulator-boot-on-l4c-v1-1-7b76c2b2ea76@oss.qualcomm.com/
CRs-fixed: 4610179

@qcomlnxci
qcomlnxci requested review from a team, aiquny, Ricardo Salveti (ricardosalveti) and Shiraz Hashim (shashim-quic) and removed request for a team October 13, 2026 06:09
… to save

power

On current Glymur Rev-1 boards, the third USB controller and PHY are
not enabled, so the L4C regulator has no active consumers. The
regulator node cannot be removed, however, since Rev-2 boards will
enable the corresponding USB hardware.

This rail may have been left enabled by the bootloader. The RPMH
regulator driver cannot query real hardware state, so without
regulator-boot-on the core assumes the rail is already off and never
issues an explicit disable during late cleanup, leaving it enabled
indefinitely while unused.

Add regulator-boot-on so the core knows to explicitly disable the
rail during late cleanup when no consumers are present.

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>

Link:https://lore.kernel.org/all/20261009-b4-regulator-boot-on-l4c-v1-1-7b76c2b2ea76@oss.qualcomm.com/
@qcomlnxci
qcomlnxci requested review from a team and Sibi Sankar (QuinAsura) and removed request for a team October 30, 2026 09:33
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #2029

PR: #2029
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41034244818

# Error File:Line PR-introduced? Root Cause
1 Git fetch failure tech/all/dt/glymur branch No Missing branch tech/all/dt/glymur in remote repository (non-fatal, fallback to commit SHA succeeded)
2 Merge conflict arch/arm64/boot/dts/qcom/Makefile No Conflict between tech/all/hawi and tech/all/maili topic branches during automerge integration

Verdict

0 of 2 errors are introduced by this PR; both are pre-existing integration issues unrelated to the PR changes.

The PR successfully merged its changes to arch/arm64/boot/dts/qcom/glymur-crd.dtsi. The build failure occurred during the subsequent automerge of unrelated topic branches, specifically when merging tech/all/maili after tech/all/hawi. The build never reached the compilation stage.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #2029

PR: #2029
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41034244818

# Error File:Line PR-introduced? Root Cause
1 Automerge conflict arch/arm64/boot/dts/qcom/Makefile No Pre-existing merge conflict between tech/all/maili-7.3-rc5-20261024 and previously merged topic branches. The conflict is unrelated to PR #2029 changes.
2 Git fetch failure tech/all/dt/glymur (branch) No Infrastructure issue: automerge attempted to fetch tech/all/dt/glymur as a branch name, but only the commit SHA exists. This was recovered automatically.

Verdict

No compilation errors found. The build failed during the pre-compilation automerge phase due to a merge conflict in arch/arm64/boot/dts/qcom/Makefile when integrating the tech/all/maili topic branch. This conflict is completely unrelated to the PR #2029 changes, which only modify arch/arm64/boot/dts/qcom/glymur-crd.dtsi. The PR itself introduces no compilation errors or build issues.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #2029 — validate-patch

PR: #2029

Verdict Issues Detailed Report
❌ 9 Full report

Final Summary

  1. Lore link present: Yes - but malformed (Link:https://... missing space after colon)
  2. Lore link matches PR commits: Cannot verify - lore fetch failed due to malformed Link tag (curl error: "No host part in the URL")
  3. Upstream patch status: Cannot verify - lore fetch failed; manual verification required at https://lore.kernel.org/all/20261009-b4-regulator-boot-on-l4c-v1-1-7b76c2b2ea76@oss.qualcomm.com/
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #2029 - FROMLIST: arm64: dts: qcom: glymur-crd: Mark L4C regulator as boot-on to save power
Upstream commit: https://lore.kernel.org/all/20261009-b4-regulator-boot-on-l4c-v1-1-7b76c2b2ea76@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - lore fetch failed due to malformed Link tag
Body preserves rationale ⏭️ Cannot verify - lore fetch failed
Fixes tag present/correct ✅ No Fixes tag needed - this is a new feature addition
Authorship preserved ⏭️ Cannot verify - lore fetch failed
Backport note (if applicable) N/A FROMLIST prefix used - not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/glymur-crd.dtsi ⏭️ Cannot verify against upstream - lore fetch failed

Issues

Critical: Malformed Link tag

  • The Link: tag is missing a space after the colon: Link:https://... should be Link: https://...
  • This formatting error caused the lore fetch to fail (curl error: "No host part in the URL")
  • Kernel commit message format requires: Link: <URL> with a space after the colon
  • This will cause checkpatch warnings and breaks automated tooling (b4, patchwork, etc.)

FROMLIST authorship requirement

  • For FROMLIST: commits, the original lore author must appear in Signed-off-by: chain
  • Current commit has: Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
  • Cannot verify if Kamal Wadhwa is the original lore author without access to the upstream patch
  • If Kamal Wadhwa is the original author, this is correct
  • If someone else posted to lore and Kamal cherry-picked it, the original author's Signed-off-by: must be preserved

Verdict

Do not merge - Fix the malformed Link: tag before merging. Add a space after Link: to make it Link: https://.... After fixing, re-run validation to verify the patch matches the upstream lore posting.

Final Summary

  1. Lore link present: Yes - but malformed (Link:https://... missing space after colon)
  2. Lore link matches PR commits: Cannot verify - lore fetch failed due to malformed Link tag (curl error: "No host part in the URL")
  3. Upstream patch status: Cannot verify - lore fetch failed; manual verification required at https://lore.kernel.org/all/20261009-b4-regulator-boot-on-l4c-v1-1-7b76c2b2ea76@oss.qualcomm.com/
  4. PR present in qcom-next/topics: Yes - commit is present in qcom-next (all added lines verified present at ref c7896917e523)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: glymur-crd: Mark L4C regulator as present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 0/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #2029 — checker-log-analyzer

PR: #2029
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/41034245388

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Not run - automerge failed
dt-binding-check ⏭️ Not run - automerge failed
dtb-check ⏭️ Not run - automerge failed
sparse-check ⏭️ Not run - automerge failed
check-uapi-headers ⏭️ Not run - automerge failed
check-patch-compliance ⏭️ Not run - automerge failed
tag-check ✅ Subject has valid FROMLIST: prefix
qcom-next-check N/A Target branch is qcom-next (prefix not required)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #2029 - FROMLIST: arm64: dts: qcom: glymur-crd: Mark L4C regulator as boot-on to save power
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/41034245388

Checker Result Summary
checkpatch ⏭️ Not run - automerge failed
dt-binding-check ⏭️ Not run - automerge failed
dtb-check ⏭️ Not run - automerge failed
sparse-check ⏭️ Not run - automerge failed
check-uapi-headers ⏭️ Not run - automerge failed
check-patch-compliance ⏭️ Not run - automerge failed
tag-check ✅ Subject has valid FROMLIST: prefix
qcom-next-check N/A Target branch is qcom-next (prefix not required)

❌ CI Infrastructure Failure — Automerge Conflict

Root cause: Merge conflict in arch/arm64/boot/dts/qcom/Makefile during automerge step prevented all checkers from running.

Failure details:

2026-10-30T09:50:08.0475081Z  ** Merging topic branch: topic/tech/all/dt/glymur
2026-10-30T09:50:09.2586593Z Auto-merging arch/arm64/boot/dts/qcom/Makefile
2026-10-30T09:50:09.2587183Z CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/Makefile
2026-10-30T09:50:09.2587800Z Auto-merging arch/arm64/boot/dts/qcom/glymur.dtsi
2026-10-30T09:50:09.3260303Z Automatic merge failed; fix conflicts and then commit the result.
2026-10-30T09:50:09.3407578Z Merge failed, manual merge

The CI attempted to merge the PR's topic branch (topic/tech/all/dt/glymur) onto baseline c7896917e523946138ce654d4b6c1e33d5a8f4e5 (qcom-next) but encountered a content conflict in the Makefile.

Analysis:

This is not a patch defect — the patch itself is well-formed:

  • ✅ Subject has valid FROMLIST: prefix
  • ✅ Contains proper Link: trailer pointing to lore.kernel.org
  • ✅ Has Signed-off-by: and Reviewed-by: tags
  • ✅ Changes only DTS file (glymur-crd.dtsi) — adds one line (regulator-boot-on;)

The conflict occurred because the baseline qcom-next branch has diverged from the PR's base, likely due to other Makefile changes merged after this PR's topic branch was created.

Fix:

The PR author or maintainer needs to rebase the topic branch onto the latest qcom-next:

# In the kernel-topics repo
git fetch origin qcom-next
git checkout topic/tech/all/dt/glymur
git rebase origin/qcom-next

# Resolve the Makefile conflict (likely just ordering of dtb entries)
# Edit arch/arm64/boot/dts/qcom/Makefile to include both sets of changes
git add arch/arm64/boot/dts/qcom/Makefile
git rebase --continue

# Force-push the rebased topic branch
git push --force-with-lease origin topic/tech/all/dt/glymur

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics
git fetch origin topic/tech/all/dt/glymur
git checkout -b test-merge origin/qcom-next
git merge origin/topic/tech/all/dt/glymur
# Conflict will appear in arch/arm64/boot/dts/qcom/Makefile

Verdict

Cannot assess patch quality — all checkers were blocked by the automerge conflict. The patch content appears clean (single-line DTS addition with proper commit message formatting), but checkers must run successfully after rebase to confirm no issues.

Action required: Rebase topic branch onto latest qcom-next to resolve Makefile conflict, then re-trigger CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants