Skip to content

arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577 - #1937

Draft
sushilsingh045 wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
sushilsingh045:qli_0_0_camera_sensor_dtsi
Draft

sushilsingh045 wants to merge 1 commit into
qualcomm-linux:tech/overlay/dtfrom
sushilsingh045:qli_0_0_camera_sensor_dtsi

Conversation

@sushilsingh045

@sushilsingh045 sushilsingh045 commented Sep 29, 2026 •

Copy link
Copy Markdown

Add camera sensor device tree support for the Draco-based Lemans EVK in QLI 0.0.
This change adds camera sensor nodes for the IMX858, OV13B10, and IMX577 sensors. These DTSI updates provide the required sensor entries and platform configuration needed for camera bring-up on the Draco-based Lemans EVK.
The change is added as part of QLI 0.0 camera sensor enablement.

CRs-Fixed: 4704394

@qcomlnxci
qcomlnxci requested review from a team, knaveen-qc, Dmitry Baryshkov (lumag) and Trilok Soni (trsoni) and removed request for a team September 29, 2026 14:10
@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from ef2488f to bec1030 Compare October 6, 2026 15:17
@qcomlnxci
qcomlnxci requested a review from a team October 6, 2026 15:18
@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from bec1030 to 1c8d707 Compare October 6, 2026 15:20
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1937

PR: #1937
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/36580700545

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'lemans-draco-evk.dtb' arch/arm64/boot/dts/qcom/Makefile:534 Yes Makefile references non-existent base DTB file lemans-draco-evk.dtb as dependency for overlay
2 No rule to make target 'lemans-draco-evk-el2.dtb' arch/arm64/boot/dts/qcom/Makefile:542 Yes Makefile references non-existent base DTB file lemans-draco-evk-el2.dtb as dependency for overlay

Verdict

Both errors are introduced by this PR. The PR adds camera overlay DTB targets that depend on base DTB files (lemans-draco-evk.dtb and lemans-draco-evk-el2.dtb) that do not exist in the tree.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1937

PR: #1937
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/36580700545

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'lemans-draco-evk.dtb' arch/arm64/boot/dts/qcom/Makefile:534 Yes PR references base DTB file lemans-draco-evk.dtb in composite target but does not create the corresponding .dts file
2 No rule to make target 'lemans-draco-evk-el2.dtb' arch/arm64/boot/dts/qcom/Makefile:542 Yes PR references EL2 variant base DTB file lemans-draco-evk-el2.dtb in composite target but does not create the corresponding .dts file

Verdict

Both errors are introduced by this PR. The PR adds Makefile rules for composite DTB targets that depend on base DTB files which do not exist in the tree.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1937 — validate-patch

PR: #1937

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1937 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Upstream commit: N/A
Verdict: ✅ PASS (vendor-only commit)

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix indicates vendor-only change
Body preserves rationale ✅ Clear description of camera sensor enablement
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved ✅ Author: Sushil Pratap Singh sussin@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds build targets for lemans-draco-evk camera overlays
arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi ✅ New file: 811 lines of camera sensor definitions
arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtso ✅ New file: 138 lines of camera overlay

Issues

None. This is a vendor-only commit with the correct QCLINUX: prefix, appropriate for device-specific camera sensor enablement that is not intended for upstream submission.

Verdict

Merge as-is. This is a properly formatted vendor-only commit adding Qualcomm-specific camera sensor device tree nodes for the Lemans Draco EVK platform.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Not checked — QCLINUX: vendor-only commit (integration_presence_report.md shows missing, but this is expected for new vendor-only changes not yet merged)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1937 — checker-log-analyzer

PR: #1937
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/36580703715

Checker Result Summary
Checker Result Summary
checkpatch ❌ 40 errors, 27 warnings: indentation (spaces vs tabs), trailing whitespace, undocumented DT strings, long commit line, missing newline at EOF
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ✅ Passed
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ⚠️ Cannot determine target branch (network unavailable); manual verification needed

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1937 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/36580703715

Checker Result Summary
checkpatch ❌ 40 errors, 27 warnings: indentation (spaces vs tabs), trailing whitespace, undocumented DT strings, long commit line, missing newline at EOF
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ✅ Passed
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ⚠️ Cannot determine target branch (network unavailable); manual verification needed

❌ checkpatch

Root cause: Multiple coding style violations in the new devicetree files — primarily mixed spaces/tabs for indentation, trailing whitespace, undocumented DT compatible strings, and a long commit description line.

Failure details:

Commit ef2488fe91d1 ("QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes...")
total: 40 errors, 27 warnings, 0 checks, 964 lines checked

ERROR: code indent should use tabs where possible (40 instances)
  #55, #99, #139, #173, #213, #255, #299, #339, #379, #423, #467, #507, #547, #591, #635, #675, #715, #759, #803, #843, #883
  FILE: arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi
  Lines with mixed spaces/tabs in property continuation lines

ERROR: trailing whitespace (4 instances)
  #213, #255, #339, #423
  FILE: arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi
  Lines ending with whitespace after property values

WARNING: DT compatible string appears un-documented (repeated):
  - "qcom,cam-res-mgr"
  - "qcom,actuator"
  - "qcom,eeprom"
  - "qcom,cam-sensor"

WARNING: Prefer a maximum 75 chars per line (commit description)

WARNING: adding a line without newline at end of file
  FILE: arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtso

Fix:

  1. Indentation errors — Replace leading spaces with tabs in property continuation lines:

    # In lemans-draco-evk-camera-sensor.dtsi, fix lines like:
    #                      "CAMIF_RESET0",
    # Should be:
    # <TAB><TAB>                     "CAMIF_RESET0",
    
    # Use editor with visible whitespace or run:
    sed -i 's/^                     /\t\t                     /' \
      arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi
  2. Trailing whitespace — Remove trailing spaces/tabs:

    sed -i 's/[[:space:]]*$//' \
      arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi
  3. Missing newline at EOF — Add newline to end of file:

    echo >> arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtso
  4. Undocumented DT strings — These are Qualcomm camera subsystem compatible strings. They are vendor-specific and may not have upstream bindings. This is acceptable for vendor-only code but will always trigger checkpatch warnings. Consider adding internal documentation if these are new strings.

  5. Long commit line — Wrap the commit body description at 75 characters (the subject line itself is acceptable).

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES \
  --git 5128906d482f6f22cbbb20d6f26d56462a6c11d7..0879014cbbac7d3263ef7ee45b18856c81dfae49

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: prefix, which is not in the checker's allowed list of upstream-linkable prefixes.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (in a maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The QCLINUX: prefix is used for vendor-only changes with no upstream equivalent. Since this is a Qualcomm-specific camera sensor devicetree addition for a vendor board (lemans-draco-evk), it is correctly tagged as QCLINUX:.

Verdict: This failure is expected and acceptable for vendor-only commits. The QCLINUX: prefix is correct for this use case. No patch change is needed — this is a checker limitation, not a patch defect.

Note: If this code is ever posted upstream, change the prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL.


⚠️ tag-check

Status: Cannot determine target branch (GitHub API unavailable).

Required action: Manually verify the PR target branch:

  1. If the target branch is qcom-next or qcom-next-staging → subject prefix is optional (✅ PASS)
  2. If the target branch is any other branch (e.g., a topic branch) → subject prefix is mandatory:
    • Current subject: QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes...
    • The QCLINUX: prefix is present → ✅ PASS

Conclusion: The commit has a valid prefix (QCLINUX:), so this check will pass regardless of the target branch.


Verdict

Fix 3 blockers before merge:

  1. ❌ Indentation errors (40 instances) — Replace spaces with tabs in property continuation lines
  2. ❌ Trailing whitespace (4 instances) — Remove trailing spaces
  3. ❌ Missing newline at EOF — Add newline to lemans-draco-evk-camx.dtso

Acceptable warnings (no action needed):

  • ⚠️ check-patch-compliance failure on QCLINUX: prefix — expected for vendor-only code
  • ⚠️ Undocumented DT compatible strings — acceptable for vendor camera subsystem nodes
  • ⚠️ Long commit description line — wrap at 75 chars (cosmetic)

Quick fix command:

# Fix indentation (adjust pattern to match your specific lines)
sed -i 's/^                     /\t\t                     /' \
  arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi

# Remove trailing whitespace
sed -i 's/[[:space:]]*$//' \
  arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi

# Add newline at EOF
echo >> arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtso

# Amend the commit
git add arch/arm64/boot/dts/qcom/lemans-draco-evk-*.{dtsi,dtso}
git commit --amend --no-edit

@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from 1c8d707 to c74fffc Compare October 9, 2026 04:44
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1937

PR: #1937
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/37886442755

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'lemans-draco-evk.dtb' arch/arm64/boot/dts/qcom/Makefile:534 Yes Makefile references non-existent base DTB file
2 No rule to make target 'lemans-draco-evk-el2.dtb' arch/arm64/boot/dts/qcom/Makefile:542 Yes Makefile references non-existent base DTB file

Verdict

Both errors are introduced by this PR. The PR adds Makefile rules for composite DTBs that depend on base device tree files (lemans-draco-evk.dtb and lemans-draco-evk-el2.dtb) which do not exist in the kernel tree.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1937

PR: #1937
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/37886442755

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'lemans-draco-evk.dtb' arch/arm64/boot/dts/qcom/Makefile:534 Yes Makefile references lemans-draco-evk.dtb as a dependency for composite DTB targets, but the base DTS file lemans-draco-evk.dts does not exist in the tree
2 No rule to make target 'lemans-draco-evk-el2.dtb' arch/arm64/boot/dts/qcom/Makefile:542 Yes Makefile references lemans-draco-evk-el2.dtb as a dependency for composite DTB targets, but the base DTS file lemans-draco-evk-el2.dts does not exist in the tree

Verdict

Both errors are introduced by this PR. The PR adds Makefile rules that reference base device tree files (lemans-draco-evk.dts and lemans-draco-evk-el2.dts) that were not included in the patch.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1937 — validate-patch

PR: #1937

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1937 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Upstream commit: N/A (vendor-only commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale ✅ Brief but adequate description of camera sensor additions
Fixes tag present/correct N/A Not a fix commit
Authorship preserved N/A Original vendor commit
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds build targets for lemans-draco-evk camera overlays
arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi ✅ New file: camera sensor definitions for imx858, ov13b10, imx577
arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtso ✅ New file: camera subsystem overlay

Issues

  • Integration presence: Commit is missing from both qcom-next and kernel-topics branches. For a QCLINUX: vendor commit, this may be expected if it's a new addition, but verify this is intentional and not a duplicate of existing work.

Verdict

This is a vendor-only camera sensor enablement commit with the correct QCLINUX: prefix. The commit message is brief but adequate, and the diff adds camera sensor device tree nodes for Lemans Draco EVK. The commit is not present in qcom-next or topics branches, which should be verified as intentional for new hardware enablement.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — commit missing from both qcom-next and topics (verify this is a new addition and not duplicate work)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: ba86f67908354f41f269ca1d64b22e4624766dcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1937 — checker-log-analyzer

PR: #1937
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/37886442789

Checker Result Summary
Checker Result Summary
checkpatch ❌ 40 errors, 26 warnings
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTBs built (skipped)
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ Invalid prefix QCLINUX:
tag-check ❌ QCLINUX: not allowed for topic branches

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1937 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/37886442789

Checker Result Summary
checkpatch ❌ 40 errors, 26 warnings
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTBs built (skipped)
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ Invalid prefix QCLINUX:
tag-check ❌ QCLINUX: not allowed for topic branches

❌ checkpatch

Root cause: Multiple coding style violations in the new DTS file — mixed spaces/tabs for indentation, trailing whitespace, undocumented DT compatible strings, and long commit message line.

Failure details:

c74fffcbe3e9 total: 40 errors, 26 warnings, 0 checks, 964 lines checked

ERROR: code indent should use tabs where possible
  (30 occurrences across multiple gpio-names properties)

ERROR: trailing whitespace
  (3 occurrences at lines 171, 370, 570)

WARNING: DT compatible string "qcom,actuator" appears un-documented
WARNING: DT compatible string "qcom,eeprom" appears un-documented  
WARNING: DT compatible string "qcom,cam-sensor" appears un-documented
  (Multiple occurrences — vendor-specific camera bindings)

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
  #7: Add camera sensor device tree nodes for the Draco-based Lemans EVK...

Fix:

  1. Indentation errors — Replace spaces with tabs in gpio-names properties:

    git rebase -i <base_sha>  # mark commit as 'edit'
    # In lemans-draco-evk-camera-sensor.dtsi, fix lines like:
    -                    "CAMIF_RESET0",
    +			"CAMIF_RESET0",
    # Use tabs (^I) not spaces for all continuation lines
  2. Trailing whitespace — Remove at lines 171, 370, 570:

    sed -i 's/[[:space:]]*$//' arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi
  3. Undocumented compatible strings — These are vendor-specific Qualcomm camera driver bindings (qcom,actuator, qcom,eeprom, qcom,cam-sensor). If these are internal/downstream-only bindings with no upstream equivalent, document them in Documentation/devicetree/bindings/media/qcom,cam-*.yaml or accept the warnings as known limitations for vendor-specific hardware.

  4. Long commit message line — Wrap the commit body at 75 chars:

    git commit --amend
    # Rewrap:
    Add camera sensor device tree nodes for the Draco-based Lemans EVK
    to enable imx858, ov13b10 and imx577 sensors
  5. Commit and continue:

    git add arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi
    git commit --amend --no-edit
    git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 53a92c131947..3b6a95ac7a57

❌ check-patch-compliance

Root cause: Commit subject uses QCLINUX: prefix, which is not in the allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Commit summary does not start with a required prefix

Fix:

The check-patch-compliance checker only accepts upstream-linkable prefixes. QCLINUX: is a vendor-internal prefix used for downstream-only changes.

If this patch has been posted to a mailing list:

git rebase -i <base_sha>  # mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577"
# Add Link: <lore-url> to the commit body
git rebase --continue

If this is a vendor-only change with no upstream equivalent:
This is a known checker limitation — QCLINUX: commits will always fail check-patch-compliance. The checker enforces upstream-first policy. If the change is genuinely vendor-specific (e.g., board-specific camera sensor wiring for an internal EVK), this failure is expected and can be acknowledged as a policy exception.

Reproduce locally:

# The checker will fail for any commit with QCLINUX: prefix
# No local reproduction needed — this is a policy check, not a technical defect

❌ tag-check

Root cause: Commit subject uses QCLINUX: prefix, but the target branch is tech/overlay/dt (a topic branch), not qcom-next or qcom-next-staging. All topic branches require a valid upstream-linkable prefix.

Failure details:

Commit c74fffcbe3e9 ("QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes...")
Target branch: tech/overlay/dt (topic branch)
Subject prefix: QCLINUX:

Fix:

The tag-check rule requires every commit targeting a topic branch (anything other than qcom-next or qcom-next-staging) to start with one of:

  • FROMLIST: — Posted to mailing list
  • FROMGIT: — Taken from a maintainer tree
  • UPSTREAM: — Merged into Linus's tree
  • BACKPORT: — Backported with modifications
  • QCLINUX: — Not allowed for topic branches
  • PENDING: — Not allowed for topic branches
  • WORKAROUND: — Temporary fix

Action:

If this patch is posted upstream or will be posted:

git rebase -i <base_sha>  # mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577"
# Add Link: <lore-url> to commit body
git rebase --continue

If this is genuinely vendor-only and will never go upstream, it should not be merged into a topic branch — topic branches are for upstream-bound work. Vendor-only changes should target qcom-next or qcom-next-staging directly, where the QCLINUX: prefix is acceptable.

Reproduce locally:

# Check commit prefix:
git log <base>..<head> --format="%H %s" | grep -vE '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|WORKAROUND):'
# Any output indicates a missing/invalid prefix

Verdict

3 blockers must be fixed before merge:

  1. checkpatch — Fix 40 indentation errors (tabs vs spaces), 3 trailing whitespace issues, and wrap commit message. The undocumented compatible string warnings are acceptable if these are vendor-specific bindings.

  2. check-patch-compliance — Change QCLINUX: to FROMLIST: (if posted upstream) or acknowledge as a known limitation for vendor-only changes.

  3. tag-check — Either change prefix to FROMLIST: (if upstream-bound) or retarget this PR to qcom-next/qcom-next-staging instead of the topic branch tech/overlay/dt. Topic branches enforce upstream-first policy and do not accept QCLINUX: prefix.

Recommended action:
If this camera sensor enablement is intended for upstream submission, fix the coding style issues, change the prefix to FROMLIST:, and add a Link: to the mailing list post. If it's vendor-only, retarget the PR to qcom-next or qcom-next-staging where QCLINUX: is acceptable.

@sushilsingh045 sushilsingh045 changed the title QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577 arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577 Oct 15, 2026
@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from c74fffc to e2733a2 Compare October 15, 2026 07:47
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1937

PR: #1937
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38701814801

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'lemans-draco-evk.dtb' arch/arm64/boot/dts/qcom/Makefile:534 Yes PR adds Makefile entries referencing lemans-draco-evk.dtb as a dependency but does not provide the base lemans-draco-evk.dts source file needed to build it

Verdict

1 of 1 errors is introduced by this PR. The build failure is entirely caused by missing the base device tree file that the new overlay depends on.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1937

PR: #1937
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38701814801

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'lemans-draco-evk.dtb' arch/arm64/boot/dts/qcom/Makefile:534 Yes PR adds composite dtb target lemans-draco-evk-camx.dtb that depends on lemans-draco-evk.dtb, but never creates the base .dts file or adds it as a build target

Verdict

1 of 1 errors is introduced by this PR. The build failure is entirely caused by incomplete device tree additions.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1937 — validate-patch

PR: #1937

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1937 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit, no upstream source
Body preserves rationale ✅ Clear description of camera sensor enablement
Fixes tag present/correct N/A Not a bug fix
Authorship preserved ✅ Sushil Pratap Singh correctly attributed
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds camera overlay build targets for lemans-draco-evk
arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi ✅ New file: camera sensor definitions (811 lines)
arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtso ✅ New file: camera overlay (138 lines)

Verdict

Merge as-is. This is a well-formed vendor-only commit adding Lemans Draco EVK camera sensor support. The QCLINUX: prefix is correctly used, commit message is clear, and the diff adds board-specific camera device tree nodes as expected for vendor board enablement.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (expected for new vendor board enablement awaiting merge)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1937 — checker-log-analyzer

PR: #1937
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38701819748

Checker Result Summary
Checker Result Summary
checkpatch ❌ 25 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check ❌ Build failure: missing base DTB file
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No relevant changes
check-patch-compliance ❌ QCLINUX: prefix not in allowed list (known limitation)
tag-check ⚠️ Cannot verify target branch (network unavailable)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1937 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38701819748

Checker Result Summary
checkpatch ❌ 25 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check ❌ Build failure: missing base DTB file
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No relevant changes
check-patch-compliance ❌ QCLINUX: prefix not in allowed list (known limitation)
tag-check ⚠️ Cannot verify target branch (network unavailable)

❌ checkpatch

Root cause: Multiple vendor-specific camera subsystem compatible strings lack DT binding documentation.

Failure details:

WARNING: DT compatible string "qcom,actuator" appears un-documented
WARNING: DT compatible string "qcom,eeprom" appears un-documented  
WARNING: DT compatible string "qcom,cam-sensor" appears un-documented

The patch introduces 25 instances of these three undocumented compatible strings across multiple camera sensor nodes in lemans-draco-evk-camera-sensor.dtsi.

Fix: Add DT binding YAML files for the camera subsystem compatible strings:

  • Documentation/devicetree/bindings/media/qcom,actuator.yaml
  • Documentation/devicetree/bindings/media/qcom,eeprom.yaml
  • Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml

Alternatively, if these are vendor-internal camera subsystem nodes not intended for upstream, document them in a vendor-specific binding location or suppress the checkpatch warnings with appropriate justification.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES \
  --git 7858adf547188cd131192a2ba999415b54912cd4..75ea5ef836efd145089c5b5616af321a2a59ebbd

❌ dtb-check

Root cause: Makefile references a non-existent base DTB file lemans-draco-evk.dtb.

Failure details:

make[4]: *** No rule to make target 'arch/arm64/boot/dts/qcom/lemans-draco-evk.dtb', 
  needed by 'arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtb'.  Stop.

The patch adds Makefile entries for composite DTB targets:

  • lemans-draco-evk-camx-dtbs := lemans-draco-evk.dtb lemans-draco-evk-camx.dtbo
  • lemans-draco-evk-camx-el2-dtbs := lemans-draco-evk-el2.dtb lemans-draco-evk-camx.dtbo lemans-camx-el2.dtbo

However, the base DTS files lemans-draco-evk.dts and lemans-draco-evk-el2.dts do not exist in the tree.

Fix:

Option 1 (if base board DTS exists elsewhere): Add the missing base board DTS files:

  • arch/arm64/boot/dts/qcom/lemans-draco-evk.dts
  • arch/arm64/boot/dts/qcom/lemans-draco-evk-el2.dts

Option 2 (if this should be an overlay only): Remove the composite DTB targets from the Makefile and only build the overlay:

-lemans-draco-evk-camx-dtbs	:= lemans-draco-evk.dtb lemans-draco-evk-camx.dtbo
-
-dtb-$(CONFIG_ARCH_QCOM)	+= lemans-draco-evk-camx.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= lemans-draco-evk-camx.dtbo
 
-lemans-draco-evk-camx-el2-dtbs    := lemans-draco-evk-el2.dtb lemans-draco-evk-camx.dtbo lemans-camx-el2.dtbo
-
-dtb-$(CONFIG_ARCH_QCOM)	+= lemans-camx-el2.dtb
-dtb-$(CONFIG_ARCH_QCOM)	+= lemans-camx-el2.dtbo

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out dtbs

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the checker's allowed list of upstream-linkable prefixes.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Commit summary does not start with a required prefix

Analysis: This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). Vendor-only commits with QCLINUX: prefix will always fail this check.

Fix:

If this is vendor-only code with no upstream equivalent: No action needed. This failure is expected for QCLINUX:-prefixed commits. The checker limitation is documented.

If this code has been or will be posted upstream: Change the prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL:

FROMLIST: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577

Add camera sensor device tree nodes for the Draco-based Lemans
EVK to enable imx858, ov13b10 and imx577 sensors

Link: https://lore.kernel.org/...
Signed-off-by: Sushil Pratap Singh <sussin@qti.qualcomm.com>

Reproduce locally:

# This checker will always fail for QCLINUX: prefixed commits
# No local reproduction needed - this is a policy check

⚠️ tag-check

Status: Cannot verify target branch (GitHub API unavailable).

Analysis: The commit uses the QCLINUX: prefix, which is valid for vendor-only changes. However, the tag-check requirement depends on the target branch:

  • If targeting qcom-next or qcom-next-staging: Subject prefix is optional → ✅ PASS
  • If targeting any other branch: Subject prefix is mandatory → ✅ PASS (has QCLINUX: prefix)

Since the commit already has a valid prefix (QCLINUX:), this check would pass for any target branch.


Verdict

3 blockers must be fixed before merge:

  1. dtb-check build failure — Add missing base DTB files (lemans-draco-evk.dts, lemans-draco-evk-el2.dts) or remove composite DTB targets from Makefile
  2. checkpatch warnings — Add DT binding documentation for qcom,actuator, qcom,eeprom, and qcom,cam-sensor compatible strings (25 instances)
  3. check-patch-compliance — Expected failure for QCLINUX: prefix; no action needed unless code will be upstreamed

Priority: Fix the dtb-check build failure first (blocker), then address checkpatch warnings (documentation gap).

@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from e2733a2 to d1e2c89 Compare October 15, 2026 13:47
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1937

PR: #1937
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38745889628

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'lemans-draco-evk.dtb' arch/arm64/boot/dts/qcom/Makefile:534 Yes Makefile references lemans-draco-evk.dtb as a prerequisite for composite DTB, but the base DTS file lemans-draco-evk.dts does not exist
2 No rule to make target 'lemans-draco-evk-el2.dtb' arch/arm64/boot/dts/qcom/Makefile:542 Yes Makefile references lemans-draco-evk-el2.dtb as a prerequisite for composite DTB, but the base DTS file lemans-draco-evk-el2.dts does not exist

Verdict

Both errors are introduced by this PR. The PR adds Makefile entries for composite DTBs that depend on base DTB files that were not included in the patch.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1937

PR: #1937
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38745889628

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'arch/arm64/boot/dts/qcom/lemans-draco-evk.dtb' arch/arm64/boot/dts/qcom/Makefile:534 Yes Makefile references non-existent base DTB file as dependency for overlay
2 No rule to make target 'arch/arm64/boot/dts/qcom/lemans-draco-evk-el2.dtb' arch/arm64/boot/dts/qcom/Makefile:542 Yes Makefile references non-existent EL2 DTB file as dependency for overlay

Verdict

Both errors are introduced by this PR. The PR adds Makefile rules that depend on base device tree files (lemans-draco-evk.dtb and lemans-draco-evk-el2.dtb) that do not exist in the kernel tree.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1937 — validate-patch

PR: #1937

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Note: The integration presence check shows this commit is not yet in qcom-next or topics branches. This is expected for new vendor-specific additions that are being introduced through this PR.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1937 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Upstream commit: N/A (vendor-only commit)
Verdict: ⚠️ N/A (QCLINUX: vendor-only)

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale ✅ Clear description of camera sensor additions
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ✅ Author: Sushil Pratap Singh
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds build rules for lemans-draco-evk-camx variants
arch/arm64/boot/dts/qcom/lemans-draco-evk-camera-sensor.dtsi ✅ New file: 811 lines of camera sensor definitions
arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtso ✅ New file: 138 lines of camera overlay

Issues

None. This is a vendor-specific device tree addition for Lemans Draco EVK camera support. The commit follows the expected pattern for QCLINUX: prefixed commits.

Verdict

This is a vendor-only commit (QCLINUX: prefix) that adds camera sensor device tree nodes for the Lemans Draco EVK board. No upstream validation is applicable or expected. The commit message is clear, authorship is correct, and the changes are self-contained device tree additions.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Note: The integration presence check shows this commit is not yet in qcom-next or topics branches. This is expected for new vendor-specific additions that are being introduced through this PR.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1937 — checker-log-analyzer

PR: #1937
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/38745872555

Checker Result Summary
Checker Result Summary
checkpatch ❌ 25 warnings - undocumented DT compatible strings
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ❌ Build failure - missing base DTB dependency
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ⚠️ Cannot verify - target branch unknown (GitHub API unavailable)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1937 - QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/38745872555

Checker Result Summary
checkpatch ❌ 25 warnings - undocumented DT compatible strings
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check ❌ Build failure - missing base DTB dependency
sparse-check ⏭️ Skipped - no C/H file changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ⚠️ Cannot verify - target branch unknown (GitHub API unavailable)

❌ checkpatch

Root cause: 25 undocumented DT compatible strings for Qualcomm camera subsystem components.

Failure details:

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented
WARNING: DT compatible string "qcom,actuator" appears un-documented
WARNING: DT compatible string "qcom,eeprom" appears un-documented
WARNING: DT compatible string "qcom,cam-res-mgr" appears un-documented

d1e2c89080922a011d803284408c495ff5152bbd total: 0 errors, 25 warnings, 0 checks, 964 lines checked

The following compatible strings are used but not documented in Documentation/devicetree/bindings/:

  • qcom,cam-sensor (multiple instances)
  • qcom,actuator (multiple instances)
  • qcom,eeprom (multiple instances)
  • qcom,cam-res-mgr (1 instance)

Fix: Add DT binding documentation for these camera subsystem components:

  1. Create Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml
  2. Create Documentation/devicetree/bindings/media/qcom,actuator.yaml
  3. Create Documentation/devicetree/bindings/media/qcom,eeprom.yaml
  4. Create Documentation/devicetree/bindings/media/qcom,cam-res-mgr.yaml

Each binding should follow the standard DT schema format with:

  • Compatible string definition
  • Required properties (reg, clocks, power supplies, etc.)
  • Optional properties
  • Example usage

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 1a2fa6edfdd16444be9e4633aec6a1d8d3dfc107..e72f08032f6a49cf909dd640861710143a030588

❌ dtb-check

Root cause: Build failure due to missing base DTB file lemans-draco-evk.dtb required by the overlay.

Failure details:

make[4]: *** No rule to make target 'arch/arm64/boot/dts/qcom/lemans-draco-evk.dtb', 
needed by 'arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtb'.  Stop.

The Makefile defines:

lemans-draco-evk-camx-dtbs := lemans-draco-evk.dtb lemans-draco-evk-camx.dtbo
dtb-$(CONFIG_ARCH_QCOM) += lemans-draco-evk-camx.dtb

This declares that lemans-draco-evk-camx.dtb depends on lemans-draco-evk.dtb (base) and lemans-draco-evk-camx.dtbo (overlay), but lemans-draco-evk.dtb does not exist in the tree.

Fix: One of the following approaches:

Option 1 (Recommended): Add the missing base DTB file:

# Create arch/arm64/boot/dts/qcom/lemans-draco-evk.dts
# Add to Makefile:
dtb-$(CONFIG_ARCH_QCOM) += lemans-draco-evk.dtb

Option 2: If lemans-draco-evk.dtb already exists in the tree but wasn't added to the Makefile, add it:

dtb-$(CONFIG_ARCH_QCOM) += lemans-draco-evk.dtb

Option 3: If the overlay should apply to a different base (e.g., lemans-evk.dtb), update the dependency:

lemans-draco-evk-camx-dtbs := lemans-evk.dtb lemans-draco-evk-camx.dtbo

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/lemans-draco-evk-camx.dtb

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the checker's allowed list of upstream-linkable prefixes.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add camera sensor nodes for imx858, ov13b10 and imx577
Commit summary does not start with a required prefix

Analysis: The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The QCLINUX: prefix is a vendor-internal tag used for Qualcomm-specific changes that have no upstream equivalent. This is a known limitation of the checker — it will always fail for vendor-only commits.

Fix: This failure is expected for vendor-only changes. No action required unless:

  1. The patch has been posted upstream → change to FROMLIST: and add Link: trailer
  2. The patch is in a maintainer tree → change to FROMGIT: and add Link: trailer
  3. The patch is merged upstream → change to UPSTREAM: and add Link: trailer

If this is genuinely a vendor-only change with no upstream equivalent, the checker failure can be ignored.


⚠️ tag-check

Status: Cannot verify - GitHub API unavailable to determine target branch.

Context: The tag-check verifies that every commit subject starts with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:). This check is mandatory for all branches except qcom-next and qcom-next-staging.

The commit uses the QCLINUX: prefix, which is valid. However, without access to the PR metadata, I cannot confirm the target branch to determine if this check applies.

If the target branch is NOT qcom-next or qcom-next-staging: ✅ PASS - the QCLINUX: prefix is valid.

If the target branch IS qcom-next or qcom-next-staging: N/A - check does not apply.


Verdict

3 blockers must be fixed before merge:

  1. Critical: Add the missing base DTB file lemans-draco-evk.dtb or fix the Makefile dependency to resolve the build failure.

  2. Required: Add DT binding documentation for the 4 undocumented camera compatible strings (qcom,cam-sensor, qcom,actuator, qcom,eeprom, qcom,cam-res-mgr).

  3. Expected failure: The check-patch-compliance failure for QCLINUX: prefix is a known checker limitation for vendor-only commits. If this is genuinely vendor-only code, this can be ignored. If the code has been posted upstream, change the prefix to FROMLIST: and add a Link: trailer.

Priority order:

  1. Fix the DTB build failure first (blocker for all validation)
  2. Add DT binding documentation (required for checkpatch compliance)
  3. Evaluate whether the QCLINUX: prefix is appropriate for this change

@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from d1e2c89 to c4005ad Compare October 16, 2026 06:48
@sushilsingh045
sushilsingh045 marked this pull request as draft October 16, 2026 06:56
@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from c4005ad to 751670f Compare October 16, 2026 07:00
@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from 751670f to f1cbfe9 Compare October 31, 2026 10:01
sensor-position-pitch = <0>;
sensor-position-yaw = <180>;
eeprom-src = <&eeprom_cam4>;
actuator-src = <&actuator_cam0>;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the actuator node referenced here. The same is used for both IMX858 and OV13B10 sensors.

…, ov13b10 and imx577

Add camera sensor device tree nodes for the Draco-based Lemans
EVK to enable imx858, ov13b10 and imx577 sensors

Signed-off-by: Sushil Pratap Singh <sussin@qti.qualcomm.com>
@sushilsingh045
sushilsingh045 force-pushed the qli_0_0_camera_sensor_dtsi branch from f1cbfe9 to 5a09cc8 Compare October 31, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants