Repository navigation
[ET][native] Bundle sample method calls in .ptn packages - #24171
Merged
meta-codesync[bot] merged 5 commits intoOct 28, 2026
Merged
Conversation
[ghstack-poisoned]
digantdesai
requested review from
JacobSzwejbka and
larryliu0820
as code owners
October 27, 2026 05:40
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24171
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled Jobs, 1 PendingAs of commit a1b2448 with merge base 4db778e ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Oct 27, 2026
This PR needs a
|
SS-JIA
approved these changes
Oct 27, 2026
meta-codesync
Bot
merged commit Oct 28, 2026
ec7a7d9
into
gh/digantdesai/177/base
218 of 221 checks passed
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #24175 * #24174 * #24173 * __->__ #24172 * #24171 Moves the prefill and decode loop of `run_llm` into `generate`, which takes a `NextToken` callback mapping logits to the next token. `run_llm` passes `greedy_argmax_last_row`, so behavior is unchanged. The verify mode later in the stack uses it to force sample tokens. Authored with Claude Code. Differential Revision: D125544385 Pull Request resolved: #24172
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #24175 * #24174 * __->__ #24173 * #24172 * #24171 Adds `read_sample_set`, which reads one `samples/<method>/<set>/` from a `.ptn` into calls with resolved tolerance. It validates like `read_samples` and rejects scalar and list values. Authored with Claude Code. Differential Revision: D125544386 Pull Request resolved: #24173
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * #24175 * __->__ #24174 * #24173 * #24172 * #24171 `export_hf_llm --samples N` adds a `golden` set to `forward`: per prompt, a prefill and 4 decode calls, each decode fed the previous eager argmax. Tolerance is (1e-3, 1e-3) for float and (2.0, 5e-2) for quantized weights, where engines quantize activations differently from torchao. Authored with Claude Code. Differential Revision: D125544388 Pull Request resolved: #24174
meta-codesync Bot
pushed a commit
that referenced
this pull request
Oct 28, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.15.0) (oldest at bottom): * __->__ #24175 * #24174 * #24173 * #24172 * #24171 `run_hf_llm --verify_samples <set>` replays a sample set through `generate()`, with a fresh context per sample. Each call's logits are compared under the sample's tolerance, then the sample's next token is forced. Exits 1 on any mismatch. Authored with Claude Code. Differential Revision: D125544389 Pull Request resolved: #24175
JakeStevens
pushed a commit
that referenced
this pull request
Oct 28, 2026
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #24171 by @digantdesai ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/digantdesai/177/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/digantdesai/177/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/digantdesai/177/orig Differential Revision: [D125544384](https://our.internmc.facebook.com/intern/diff/D125544384/) @diff-train-skip-merge Co-authored-by: Digant Desai <digantdesai@meta.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
A
.ptncan carry recorded method calls undersamples/<method>/<set>/as
index.jsonplusdata.safetensors; program loaders ignore them. Asample is an ordered list of calls from the initial state with no reset
between, so stateful methods such as LLM prefill then teacher-forced decode
can be checked. Tolerance resolves per call, then sample, then set, and
write_sampleswarns above 1e-3.write_samplesandread_sampleslive inexir/_serialize/_ptn_samples.py. The spec is inbackends/native/README.md;review it first.
Authored with Claude Code.
Differential Revision: D125544384