Skip to content

Let pyperformance decide unpack sequence loops - #451

Open
Fidget-Spinner wants to merge 1 commit into
python:mainfrom
Fidget-Spinner:fix_unpack_sequence
Open

Fidget-Spinner wants to merge 1 commit into
python:mainfrom
Fidget-Spinner:fix_unpack_sequence

Conversation

@Fidget-Spinner

Copy link
Copy Markdown
Member

Fixes #450

@corona10 corona10 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. But I prefer to discuss this change at CHIPS because it will affect to benchmark history.

@vstinner

Copy link
Copy Markdown
Member

On modern computers, unpack_sequence completes in nanoseconds (!!!).

IMO it would be better to remove such micro-benchmark, it doesn't fit well with pyperformance.

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Copying from Discord for posterity) Hmmm, I don't think this will reduce the noise? inner_loops will only change how the result is reported, and not how long pyperf runs the benchmark, so this would just make the number 400x bigger with the same noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unpack_sequence benchmark too fast on modern computers

4 participants