Repository navigation
Avoid blocking reads in the sync implementation. - #1778
Merged
Merged
Conversation
aaugustin
force-pushed
the
issue-1777
branch
4 times, most recently
from
October 14, 2026 19:54
556811e to
bdd2e2c
Compare
This makes it possible to interrupt it reliably. Fix #1777. Add tests for the "unexpected error" path, which isn't execised by tests anymore since we don't interrupt recv() anymore by closing the socket. Improve consistency with the trio implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to interrupt it reliably.
Fix #1777.