Repository navigation
Release metadata references in partition_unique - #502
Open
harbinresearcher wants to merge 1 commit into
Open
harbinresearcher wants to merge 1 commit into
harbinresearcher wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partition_uniqueretains metadata references for all inputs, including records discarded bykeep="first"and records replaced bykeep="last". Completed partitions also emit nested metadata lists, so the shared reference helpers cannot release the retained counters. A synchronous sink can finish while those counters remain nonzero.Release the metadata belonging to discarded records, and flatten the retained records metadata before emission. Downstream nodes still acquire their own references; a buffering
collectretains them until its flush completes. Value ordering, partition size and the key API are unchanged. The similar timed-window node is outside this patch.Fixes #501.
Validation:
test_create_file(missing Graphvizdot),test_tcp_word_count_example(connection refused), andtest_tcp_async(60-second timeout). No test filtering, timeout extension or coverage exclusion was added. This is a baseline comparison, not a claim that the complete suite is green.core.pyremains 95%, with the same number of uncovered statements (43).AI disclosure: Codex prepared this autonomous contribution under the account owner authorization, including investigation, implementation, tests and a separate agent review. No production incident or active deployment is claimed.