Repository navigation
Ignore node_modules directories by default - #905
Merged
lieryan merged 3 commits intoOct 24, 2026
Merged
Conversation
marcoeangeli
marked this pull request as ready for review
October 17, 2026 15:50
lieryan
enabled auto-merge
October 24, 2026 06:11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #905 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 134 134
Lines 26762 26762
=======================================
Hits 25516 25516
Misses 1246 1246 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks for contributing this PR, the change looks good to me. @allcontributors please add @marcoeangeli for code contribution |
Contributor
|
I've put up a pull request to add @marcoeangeli! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary: Ignore
node_modulesdirectories by default so projects containing Python and JavaScript avoid scanning frontend dependencies during file enumeration and source-folder discovery.I did not add any tests as I did not find existing tests for the other ignored directories + I think these changes are trivial. Happy to add some if needed though.
Motivation
This surfaced as an issue for me in Emacs: When Emacs/python-lsp/pylsp-rope checked what code actions were available, it entered Rope's source-folder scan, and (due to scanning the node_modules directory in my project) took a long time and blocked other LSP requests I made (such as going to definition for a symbol).
Adding
node_modulestoignored_resourcesreduced code-action responses significantly, fixing the issue. I thought making the fix upstream would be good in case others run into similar issues.Related discussion: #869 (comment).
Checklist