Repository navigation
Declare PyQt5 through an optional compatibility extra - #217
Merged
Merged
Conversation
altendky
added a commit
that referenced
this pull request
Oct 23, 2026
Python 3.10 CI resolves pytest 9.1.1, whose logging module uses match statements that the pinned mypy 0.930 cannot parse. The QFlags typing test imports pytest and fails on that syntax, leaving 403 tests passing and one failing on each OS. Constrain the development extra's pytest dependency below major version 9. This keeps pytest compatible with the existing mypy pin and applies to tox's test environments through the development extra. Record the compatibility bound in the changelog. Observed failure: https://github.com/python-qt-tools/PyQt5-stubs/actions/runs/40006937968/job/120597131802 Validation: All nine Python 3.8–3.10 / Linux, macOS, and Windows matrix jobs pass, along with the aggregate check. Confirmed Python 3.10 resolves pytest 8.4.2 while retaining mypy 0.930; its full suite passes all 404 tests. Whitespace checks pass. This is independent of the optional compatibility extra in #217.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the pyqt5 extra so PyQt5 version compatibility constraints can be declared in package metadata and enforced by dependency resolvers when users opt in. No PyQt5 version bounds are introduced in this change.
Document compatibility enforcement as the purpose of the extra. Selecting it may also cause pip to install PyQt5 as a side effect of satisfying the dependency. Update the changelog; existing development dependencies remain unchanged.
Validation: Built a wheel and source distribution with Python 3.12 and setuptools 75.8.0. Verified that the binding requirement is conditional on the extra, other dependencies are preserved, and all 50 packaged stub files are byte-for-byte identical to the base branch. Reviewed the documentation correction and checked whitespace.