Skip to content

Fix LSP kind for Jedi string completions - #734

Open
AryanRG wants to merge 1 commit into
python-lsp:developfrom
AryanRG:fix/jedi-string-completion-kind
Open

AryanRG wants to merge 1 commit into
python-lsp:developfrom
AryanRG:fix/jedi-string-completion-kind

Conversation

@AryanRG

@AryanRG AryanRG commented Oct 17, 2026

Copy link
Copy Markdown

Fixes #472.

Jedi reports dictionary-key completions with type string. The existing type map emits a present completion kind of null; LSP defines a present kind as an integer enum. Map string completions to CompletionItemKind.Value without changing labels or insertion text.

Validation:

  • Two new regression cases fail on the pristine base and pass with this change.
  • Python 3.9 with Jedi 0.17.2: 9 focused tests passed.
  • Python 3.12 full local suite: 201 passed, 10 skipped, 2 failed. The same two failures (PyQt and Matplotlib completion cases) also occur on the untouched base, where Jedi returns no completions.
  • Ruff check and format check passed.

AI assistance was used to investigate, implement, test, and review this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyslp_completions emits an invalid kind key with objects named Kind

1 participant