Skip to content

Fix significant-digit rounding after fractional carry #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vera-rubin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix significant-digit rounding after fractional carry #1388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions babel/numbers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,9 @@ def _format_significant(self, value: decimal.Decimal, minimum: int, maximum: int
exp = value.adjusted()
scale = maximum - 1 - exp
digits = str(value.scaleb(scale).quantize(decimal.Decimal(1)))
# Account for a carry that increases the number of digits.
if len(digits) > maximum:
exp += 1
if scale <= 0:
result = digits + '0' * -scale
else:
Expand Down
10 changes: 10 additions & 0 deletions tests/test_numbers_format_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,16 @@ def test_significant_digits():
assert numbers.format_decimal(0.1, '@@', locale='en_US') == '0.10'


def test_significant_digits_fractional_carry():
for value, expected in [
('0.00994', '0.0099'),
('0.00999', '0.010'),
('0.0999', '0.10'),
('0.000999', '0.0010'),
]:
assert numbers.format_decimal(decimal.Decimal(value), '@@', locale='en_US') == expected


def test_decimals():
"""Test significant digits patterns"""
assert numbers.format_decimal(decimal.Decimal('1.2345'), '#.00', locale='en_US') == '1.23'
Expand Down