Repository navigation
Conversation
Resolve missing list-pattern parts individually without mutating locale data. Follow the CLDR root chain for unit-narrow so narrow lists do not fall back to unrelated wide-unit parts. Cover partial start/end patterns, missing two-item patterns, precedence, and locale-cache preservation with regressions.
AryanRG
marked this pull request as ready for review
October 14, 2026 13:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_listselects the first existing style even when that style only defines some pattern parts. This raisesKeyErrorfor valid inputs such as Germanunitand Frenchstandard-narrowlists with three items. When2is missing butstartandendexist, two-item lists can repeat the last item: Wolofunit-narrowformats["A", "B"]as"A B B".Resolve each missing part through the fallback styles, preserving the requested style's parts and collecting the result in a fresh dictionary so cached locale data is unchanged. Correct the
unit-narrowchain tounit-shortthenstandard, matching the root aliases in CLDR 45 and 48.2. The previous extraunitstep could select wide-unit parts; removing it also changes Urdu two-item narrow lists from"A، B"to"A اور B"(includingur_PKandur_IN).Related to #781 and the whole-style fallback added in #1099 for #1098. #781's original German
standard-narrowexample already works on current master; this addresses the remaining partial-style failures and missing-two-item-pattern behavior.Validation with generated CLDR 48.2 data:
TZ=UTC: 7,846 passed, 7 skipped, 2 xfailed (baseline: 7,831 passed).The local timezone tests fail on the untouched base without
TZ=UTC; the same timezone setting was used for the before/after full-suite comparison.