Repository navigation
Conversation
When all entries in a remote's includes field are sha256 digests, bypass the expensive /tags/list enumeration and fetch manifests directly by digest. Cosign companion tags are discovered via cached HEAD probes filtered through the remote's excludes, fixing the signed_only ordering bug where signature checks ran before cosign discovery. Only HTTP 404 is treated as tag absence; auth failures and rate limits propagate. Tested against Satellite 6.19.5 with openshift-release-dev/ocp-v4.0-art-dev (50,000+ tags). SAT-49501
Extends the tag list bypass to support name=sha256:digest entries in the remote's includes field. When a digest has an alias, a local tag with the alias name is created alongside the digest reference, enabling friendly image names in disconnected environments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includesusing the formatname=sha256:<digest>create human-readable tags alongside the digest, enabling friendly image references in disconnected environmentscli,cluster-dns-operator) rather than a raw sha256 digestImplementation
_parse_include_entry()static method validates and parses both plain digests andname=sha256:digestentries_can_bypass_taglist()updated to accept alias entries_process_manifestscreatesTagDeclarativeContent for each alias alongside the digest-tagged manifestDepends on
Test plan
TestParseIncludeEntry, updatedTestCanBypassTaglistwith alias casesChangelog
CHANGES/2474.1.feature— new changelog entry for alias support