Repository navigation
fix(chat-plugins): pin AES-GCM auth tag to 16 bytes when unsealing plugin tokens - #324
Merged
Merged
Conversation
…g plugin tokens semgrep gcm-no-tag-length (blocking): createDecipheriv without authTagLength accepts a truncated tag, which makes forging a sealed token far cheaper. Refuse any tag that is not 16 bytes and pass authTagLength: 16. This finding fails semgrep on every open PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan14 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 9 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semgrep
gcm-no-tag-length(blocking) onapps/web/src/lib/chat/plugin-store.ts(from #315):createDecipherivwithoutauthTagLengthaccepts a truncated GCM tag, which makes forging a sealed plugin token far cheaper. Now any tag that is not 16 bytes is refused andauthTagLength: 16is passed.This finding fails semgrep on every open PR (e.g. #318). Tests: plugin-store 13/13 on vienna, including a new truncated-tag case.
🤖 Generated with Claude Code