Repository navigation
Forward default options from the parser factory - #345
Open
Aurantium-47 wants to merge 1 commit into
Open
Aurantium-47 wants to merge 1 commit into
Aurantium-47 wants to merge 1 commit into
Conversation
Pass documented factory options to Processor and expose the optional argument in the TypeScript overloads. Cover default options and per-call overrides without changing Processor semantics. Assisted-by: OpenAI GPT-6 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented
parser(transform, options)API drops its second argument. For example,parser(undefined, { lossless: false }).processSync('a > b')returnsa > binstead ofa>b.Forward the default options to
Processorand expose the optional argument in the existing TypeScript overloads. The processor already merges defaults with per-call options. Four regression tests cover synchronous and asynchronous whitespace handling, a custom nesting limit, asynchronous rule mutation, and per-call overrides. Type checks cover omitted transforms, return inference, and the existing restriction on calling async processors synchronously.Validation on Windows with Node 24.15.0:
git diff --checkpass. Lint reports two existing unnecessary-escape warnings inexceptions.mjs.Developed and tested with OpenAI Codex assistance.