Skip to content

fix: set parents for all variadic inserted nodes #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feritcemkahraman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: set parents for all variadic inserted nodes #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/__tests__/container.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@ import test from "./util/runner.mjs";
import parser from "../../dist/index.js";
import { parse } from "./util/helpers.mjs";

for (const method of ["insertBefore", "insertAfter"]) {
test(`container#${method} sets parents of every inserted node`, (t) => {
const selector = parser().astSync("a").first;
const first = parser.className({ value: "first" });
const second = parser.className({ value: "second" });
selector[method](selector.first, first, second);
t.is(first.parent, selector);
t.is(second.parent, selector);
second.remove();
t.is(selector.nodes.includes(second), false);
t.is(second.parent, undefined);
});
}

test("container#append", (t) => {
let out = parse("h1", (selectors) => {
let selector = selectors.first;
Expand Down
2 changes: 2 additions & 0 deletions src/selectors/container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ export default class Container extends Node {
let oldIndex = this.index(oldNode);
const resetNode = [];
for (let i = 2; i < arguments.length; i++) {
arguments[i].parent = this;
resetNode.push(arguments[i]);
}
this.nodes.splice(oldIndex + 1, 0, newNode, ...resetNode);
Expand All @@ -103,6 +104,7 @@ export default class Container extends Node {
let oldIndex = this.index(oldNode);
const resetNode = [];
for (let i = 2; i < arguments.length; i++) {
arguments[i].parent = this;
resetNode.push(arguments[i]);
}
this.nodes.splice(oldIndex, 0, newNode, ...resetNode);
Expand Down