Repository navigation
fix: inspect the project Python environment #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tdstein
wants to merge
12
commits into
main
Choose a base branch
from
symphony/posit-dev_rsconnect-python_889-e922273cb0dbb9c6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2468e90
fix: inspect the project Python environment
tdstein d856bfa
fix: harden project environment inspection and use it in preflight
tdstein 5be9911
chore: merge main into symphony/posit-dev_rsconnect-python_889-e92227…
tdstein 724aa84
fix: address project environment inspection review
tdstein dae4b46
chore: merge main into symphony/posit-dev_rsconnect-python_889-e92227…
tdstein 0e0197a
chore: merge main into symphony/posit-dev_rsconnect-python_889-e92227…
tdstein 0d12e08
chore: merge main into symphony/posit-dev_rsconnect-python_889-e92227…
tdstein 75bc488
chore: merge main into symphony/posit-dev_rsconnect-python_889-e92227…
tdstein 8977943
chore: merge main into symphony/posit-dev_rsconnect-python_889-e92227…
tdstein b35b37e
fix: let the environment inspector import from user site and PYTHONPATH
tdstein 5ac3ecf
fix: flush nbconvert stderr before reporting a static render failure
tdstein c07c30d
fix: align uv freeze with pip exclusions
tdstein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 The .venv search keeps going up to the filesystem root, so it can pick up an unrelated environment. The test
test_project_environment_lookup_ignores_non_ancestorscovers sibling directories, but no test covers an ancestor that is outside the project.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 The requested lookup explicitly includes the deployment directory’s ancestors without a project-root boundary, so this search intentionally continues to the filesystem root. A boundary would change the specified precedence and exclude legitimate parent environments. An explicit --python overrides discovery; I’ll add coverage documenting the ancestor behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tell me a joke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't programmed jokes into it.