Skip to content

Require pip 20.3 for dependency inspection - #917

Closed
tdstein wants to merge 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_916-ea21c4d9d16d314b
Closed

tdstein wants to merge 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_916-ea21c4d9d16d314b

Conversation

@tdstein

@tdstein tdstein commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

generated requirements
  pip < 20.3: report an upgrade or requirements-file option
  pip >= 20.3: freeze with named rsconnect exclusions
all requirement sources
  filter rsconnect distributions and validate local editables

The shared filtering and editable validation in this PR overlap with the proposed fix in #909, which is still open. They are included because the current base lacks that foundation.

Evidence

  • Before: filtering dropped my-rsconnect-utils and paths containing rsconnect.
  • After: 281 focused tests passed; actual inspection passed with pip 20.3, 25.0.1 and 26.3, and pip 20.2.4 returned the upgrade error while requirements-file inspection continued to work.

Merge Danger

Door: two-way. Older publishing environments need a pip upgrade to generate requirements.

Blast Radius: deployments using generated Python requirements.

Closes #916

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-11-05 15:39 UTC

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11082 9783 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/subprocesses/inspect_environment.py 93% 🟢
TOTAL 93% 🟢

updated for commit: e9b4592 by action🐍

@tdstein

tdstein commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Superseded by #909, which now includes this PR's pip >=20.3 requirement, named freeze exclusions, documentation, and compatibility tests alongside the shared filtering and editable validation. #909 closes both #899 and #916.

@tdstein tdstein closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate minimum pip version and native pip freeze exclusions

1 participant