Repository navigation
Drop geogram includes (companion to polyfem#559) - #19
Open
danielepanozzo wants to merge 1 commit into
Open
danielepanozzo wants to merge 1 commit into
danielepanozzo wants to merge 1 commit into
Conversation
PolyFEM no longer depends on geogram (polyfem/polyfem#559): its headers and polyfem/utils/GeogramUtils.hpp are gone. The bindings only kept unused includes of geogram's command_line headers and of GeogramUtils; nothing from them is used anymore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ULwCxzyjTs5GTmQ1QHFF6k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to polyfem/polyfem#559, which removes geogram from PolyFEM, including
polyfem/utils/GeogramUtils.hpp.The bindings no longer call anything from geogram; they only kept three unused includes, which this PR deletes:
src/binding.cpp:geogram/basic/command_line.handgeogram/basic/command_line_args.hsrc/state/state.cpp:polyfem/utils/GeogramUtils.hppWithout this, the bindings stop compiling as soon as the PolyFEM pin moves past #559. The pin is not changed here.
Testing
polyfem@e8bd3d3). That pin's geogram passes-msse3, which Apple Clang rejects on arm64, and its amgcl needs CMake < 4.-fsyntax-onlyon both edited files using the project's owncompile_commands.json.src/binding.cpppasses.src/state/state.cppreports one error,no member named 'update_dirichlet_nodes'. The unmodified upstream file reports the same error, so it is not related to this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01ULwCxzyjTs5GTmQ1QHFF6k