Skip to content

feat: Update get method documentation and handle non-existent cache keys in Redis driver #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madwings wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: Update get method documentation and handle non-existent cache keys in Redis driver #84

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fa0ec1
fix: Update get method documentation and handle non-existent cache ke…
madwings Nov 2, 2026
4bbda78
fix: Update get method to handle settype() failures and improve error…
madwings Nov 2, 2026
6695c8c
fix: Update get method documentation to clarify return values for cac…
madwings Nov 2, 2026
f93e7d6
Improve documentation for get method return type
madwings Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions system/libraries/Cache/drivers/Cache_redis.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ public function __construct()
* Get cache
*
* @param string $key Cache ID
* @return mixed
* @return mixed Cached value, NULL for a missing key, unsupported type or failed conversion;
* FALSE if unserialization fails or the legacy Redis GET fallback returns FALSE
* @throws ValueError If settype() is given an invalid type (PHP 8+)
*/
public function get($key)
{
Expand All @@ -180,10 +182,10 @@ public function get($key)
case 'NULL':
return settype($data['__ci_value'], $data['__ci_type'])
? $data['__ci_value']
: FALSE;
: NULL;
case 'resource':
default:
return FALSE;
return NULL;
}
}

Expand Down