Repository navigation
Conversation
Herafia
force-pushed
the
fix/ticket-observer-readonly-fields
branch
from
September 30, 2026 07:53
cbf1133 to
bd189b5
Compare
Rom1-B
requested changes
Sep 30, 2026
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
Can you add a test covering PluginFieldsContainer::preItemUpdate() directly (e.g. a central-interface user without ticket update right but with write access on the container) asserting _plugin_fields_data is stripped/not persisted?
stonebuzz
requested changes
Sep 30, 2026
Herafia
force-pushed
the
fix/ticket-observer-readonly-fields
branch
from
September 30, 2026 15:26
6262e88 to
83e4dc2
Compare
stonebuzz
requested changes
Oct 1, 2026
Rom1-B
requested changes
Oct 2, 2026
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
Please address ALL the previous comments before requesting a review again
Herafia
force-pushed
the
fix/ticket-observer-readonly-fields
branch
from
October 6, 2026 12:12
b0870ef to
9b45100
Compare
Contributor
|
Please fix CI |
RomainLvr
approved these changes
Oct 12, 2026
Herafia
force-pushed
the
fix/ticket-observer-readonly-fields
branch
from
October 12, 2026 15:04
143e2ce to
7ea9cac
Compare
Rom1-B
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
because rights were only checked at the container-profile level, not against the
specific item. Fields are now rendered as read-only for users who cannot update the
item, and the pre_item_update hook enforces the same check server-side.