Repository navigation
fix: an unparsable config file no longer deletes the database entry on import - #239
Open
PaulRichez wants to merge 2 commits into
Open
PaulRichez wants to merge 2 commits into
PaulRichez wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
readConfigFilereturnsnullonly when the file doesn't exist (ENOENT). When the file exists but isn't valid JSON, it throws an error naming the file.Why is it needed?
A merge conflict left in a sync file deleted the config (here the Public role) on import. See #238.
How to test it?
The new integration test
Import (unparsable file)breaksuser-role.public.json, imports it, checks the error, puts the file back and checks the diff is empty (the role is still in the database). It fails without the fix.Lint and integration tests pass locally (Node 22, playground on Strapi 5.37).
Related issue(s)/PR(s)
Fixes #238