Repository navigation
chore(deps): bump @lightningjs/renderer to 3.7.0 - #149
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @lightningjs/renderer from 3.1.1 to 3.7.0 and re-ports our patch. Frames are cheaper (Plex Home in headless Chrome, 6 runs per cell, old and new alternated): renderer frame median 4.1 to 3.4 ms at 4x and 6.1 to 5.0 ms at 6x held scroll, p95 15.0 to 10.8 ms, gl.uniform calls per frame 1010 to 75, draw calls per frame 216 to 186, bindTexture -36% in held scroll. The machine was loaded by other benchmarks while this ran, so read it as a direction.
Two commits
The animation regression (the new patch hunk): since 3.1.2 AnimationManager.update walks the list backwards with swap-remove, so two animations on the same property that end in the same frame leave the older value on screen. On Home that froze the UltraBlur background on the previous row's colors in 3 of 3 runs, 3.1.1 and the patched build updated in 3 of 3. The patch removes in order and compacts after the loop, same O(n) per frame. Should go upstream too.
Things to know