Repository navigation
Assert gRPC UNIMPLEMENTED status for unknown methods - #1793
Merged
Merged
Conversation
Check UNIMPLEMENTED as well as HTTP 200 so the sample test verifies the RPC error. Replace the old trailer TODO with the assertion already used by Play gRPC’s upstream test.
Contributor
|
This pull request is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the unknown gRPC method test by asserting
grpc-status: UNIMPLEMENTEDalongside HTTP 200. Replace the outstanding TODO and rename the test to describe the expected gRPC status.Validated locally on Java 17 with Pekko HTTP: Scala 2.13.18 and 3.3.9, each with sbt 1.13.0 and 2.1.0. All eight tests passed in each of the four combinations; sbt 2 used
testFull.