Skip to content

Assert gRPC UNIMPLEMENTED status for unknown methods - #1793

Merged
mkurz merged 1 commit into
playframework:mainfrom
mkurz:test-grpc-unimplemented-status
Nov 20, 2026
Merged

mkurz merged 1 commit into
playframework:mainfrom
mkurz:test-grpc-unimplemented-status

Conversation

@mkurz

@mkurz mkurz commented Nov 20, 2026

Copy link
Copy Markdown
Member

Complete the unknown gRPC method test by asserting grpc-status: UNIMPLEMENTED alongside HTTP 200. Replace the outstanding TODO and rename the test to describe the expected gRPC status.

Validated locally on Java 17 with Pekko HTTP: Scala 2.13.18 and 3.3.9, each with sbt 1.13.0 and 2.1.0. All eight tests passed in each of the four combinations; sbt 2 used testFull.

Check UNIMPLEMENTED as well as HTTP 200 so the sample test verifies the RPC error. Replace the old trailer TODO with the assertion already used by Play gRPC’s upstream test.
@mergify

mergify Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

This pull request is merged.

@mkurz
mkurz merged commit 1f77e91 into playframework:main Nov 20, 2026
59 checks passed
@mkurz
mkurz deleted the test-grpc-unimplemented-status branch November 20, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant