Repository navigation
Conversation
SLIP-39 allows only printable ASCII in a passphrase, as shamir_mnemonic.generate_mnemonics checks; mnemonics now checks it too. The identifier and encrypted-secret passphrase checks were asserts, which python -O removes; they now raise ValueError.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mnemonicsaccepts a passphrase that is not printable ASCII, which SLIP-0039 forbids andshamir_mnemonic.generate_mnemonicsrefuses. It also checks the identifier withassert, so underpython -Oa 16-bit identifier withextendable=Falsegives shares that recover a different master secret.I check the passphrase as
generate_mnemonicsdoes, and raiseValueErrorfor an identifier out of range. The check that refuses a passphrase with an encrypted master secret was anasserttoo, so under-Othat passphrase was silently ignored; it now raisesValueErroras well. The three new tests inapi_test.pyfail on master and pass here, with and without-O. Closes #27.