Repository navigation
Fix #627 - Accept ON as value in SET statements - #652
Open
predictor2718 wants to merge 3 commits into
Open
predictor2718 wants to merge 3 commits into
predictor2718 wants to merge 3 commits into
Conversation
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.11.x #652 +/- ##
============================================
- Coverage 96.92% 96.51% -0.42%
- Complexity 2316 2355 +39
============================================
Files 71 71
Lines 5110 5189 +79
============================================
+ Hits 4953 5008 +55
- Misses 157 181 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
williamdes
approved these changes
Oct 13, 2026
williamdes
left a comment
williamdes
left a comment
Member
There was a problem hiding this comment.
Thank you, can you add a test case please ?
predictor2718
force-pushed
the
fix/627-set-variable-on
branch
from
October 13, 2026 18:31
f97a3a3 to
a204ecd
Compare
Contributor
Author
|
Thanks for the review! I added a test case: |
predictor2718
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SET @@variable = ONfailed with "Missing expression" becauseONis a reserved keyword thatExpression::parse()rejectedOFFworked because it is not a reserved keywordSetOperation::parse(), afterExpression::parse()returns null, acceptONas a literal value sinceit is valid in SET statements
Fixes #627