Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HalfVector compares its uint16 storage rather than its numeric values, so vectors containing +0.0 and -0.0 compare unequal. Small positive and negative values that both round to zero expose the same issue. Vector and HalfVector in v0.4.2 use numeric equality.
Compare the decoded values instead. Keep the existing type check and preserve the stored sign bits, text serialization, and binary serialization. The regression tests cover direct construction, float16 underflow, text decoding, and binary decoding.
Validation: the five new cases failed on the unchanged implementation. The focused HalfVector, Vector, SparseVector, and Bit suites pass (60 passed, 8 skipped because SciPy is not installed). No PostgreSQL integration suite was run.
Prepared with assistance from OpenAI Codex. No independent human review is implied.