Skip to content

Fixed parsing of empty sparsevec in SparseVector #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OsamaAnsar wants to merge 1 commit into from
Closed

Fixed parsing of empty sparsevec in SparseVector #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/sparse-vector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,14 @@ export class SparseVector {

this.dimensions = parseInt(parts[1]);

const elements = parts[0].slice(1, -1).split(',');
for (const element of elements) {
const ep = element.split(':', 2);
this.indices.push(parseInt(ep[0]) - 1);
this.values.push(parseFloat(ep[1]));
// all-zero vectors are {}/n
const body = parts[0].slice(1, -1);
if (body !== '') {
for (const element of body.split(',')) {
const ep = element.split(':', 2);
this.indices.push(parseInt(ep[0]) - 1);
this.values.push(parseFloat(ep[1]));
}
}
}

Expand Down
10 changes: 10 additions & 0 deletions tests/sparse-vector.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@ test('fromSql', () => {
assert.deepEqual(vec.values, [1, 2, 3]);
});

test('fromSqlEmpty', () => {
const vec = new SparseVector('{}/3');
assert.deepEqual(vec.toArray(), [0, 0, 0]);
assert.equal(vec.dimensions, 3);
assert.deepEqual(vec.indices, []);
assert.deepEqual(vec.values, []);
assert.equal(vec.toPostgres(), '{}/3');
assert.deepEqual(Object.keys(vec.toArray()), ['0', '1', '2']);
});

test('fromDense', () => {
const vec = new SparseVector([1, 0, 2, 0, 3, 0]);
assert.equal(vec.toPostgres(), '{1:1,3:2,5:3}/6');
Expand Down