Skip to content

fix(parser): preserve shard pinning for all queries - #1892

Merged
meskill merged 2 commits into
mainfrom
meskill-2026-10-23-fix-parser---xmo
Oct 25, 2026
Merged

meskill merged 2 commits into
mainfrom
meskill-2026-10-23-fix-parser---xmo

Conversation

@meskill

@meskill meskill commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Make sure we can pin the transaction to specific shard and the next Describe request will be routed only to this pinned shard

@meskill
meskill requested a review from jkaczman October 23, 2026 15:25
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

ProjectPgDog
Branchmeskill-2026-10-23-fix-parser---xmo
TestbedIntel v1

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

🚨 2 Alerts

🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Metal bench passed. All 150 measures within bounds.

suite throughput cpu/txn user cycles/txn user instr/txn kernel cycles/txn ctx/txn
pooler 28.16 (-0.1% ± 0.7%) 29,425 (+0.8% ± 1.1%) 35,782 (+0.0% ± 0.02%) 37,810 (-0.8% ± 1.2%)
lb 29.09 (+0.0% ± 0.8%) 30,699 (+0.3% ± 1.1%) 36,648 (+0.0% ± 0.02%) 38,835 (-0.2% ± 1.4%)
sharding-w2 52.46 (-0.5%) 68,833 (-0.0%) 73,022 (-0.0%) 59,165 (-2.1%) 1.404 (+0.3%)
sharding-w8 156,809 (+1.7%) 46.72 (-2.0%) 67,735 (-3.0%) 56,712 (+0.0%) 52,684 (-0.7%) 0.1462 (+2.2%)
Counters per txn
suite br mispred l1i refill backend stall
pooler 82.33 (+0.9% ± 3.0%) 3,410 (+0.7% ± 0.9%) 2,480 (-0.1% ± 1.9%)
lb 85.77 (+1.0% ± 2.0%) 3,488 (+0.3% ± 1.0%) 2,654 (+0.4% ± 1.6%)
sharding-w2 314 (+0.0%) 5,498 (-0.1%) 6,529 (-2.0%)
sharding-w8 337 (+1.8%) 5,203 (-0.0%) 8,704 (-9.2%)

Microbench: all 135 measures within bounds.

  • simple_cold: 13 of 15 benches slower, median +1.3% ± 0.5%
lb flamegraph vs f5632bc

lb

Open interactive for hover, zoom and search.

lb removed

Open interactive.

microbench flamegraph vs f5632bc

microbench

Open interactive for hover, zoom and search.

microbench removed

Open interactive.

pooler flamegraph vs f5632bc

pooler

Open interactive for hover, zoom and search.

pooler removed

Open interactive.

sharding-w2 flamegraph vs f5632bc

sharding-w2

Open interactive for hover, zoom and search.

sharding-w2 removed

Open interactive.

sharding-w8 flamegraph vs f5632bc

sharding-w8

Open interactive for hover, zoom and search.

sharding-w8 removed

Open interactive.

Logs

lb, microbench, pooler, sharding-w2, sharding-w8, verdict.json

Compared d3d3ace with f5632bc.

@meskill
meskill merged commit f746643 into main Oct 25, 2026
60 of 62 checks passed
@meskill
meskill deleted the meskill-2026-10-23-fix-parser---xmo branch October 25, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant